-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BME680 module initial commit #2151
Conversation
docs/en/modules/bme680.md
Outdated
| :----- | :-------------------- | :---------- | :------ | | ||
| 2017-10-28 | [vsky279](https://github.com/vsky279) | [vsky279](https://github.com/vsky279) | [bme680.c](../../../app/modules/bme680.c)| | ||
|
||
Copyright (C) 2017 - 2018 Bosch Sensortec GmbH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this copyright for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using parts of the bme680.c driver from Bosch - it says we should retain the copyright. I think maybe just one line should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that, yes. However, I thought leaving the copyright in the source code would be enough. It feels somewhat out of place here and makes it look like Bosch contributed the NodeMCU module (and wrote this documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. I will make a block in the code with these functions and will put the (c) note there.
I'm afraid that due to lack of hardware this will probably not happen. However, a code review can still be conducted. |
I see that this uses doubles to perform calculations... Does this work in an integer build? |
Yes, it does. This is even tested in the BME280 module. |
Fixes #2114.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
dev
branch rather than formaster
.docs/en/*
.This is a simple driver of the Bosch's BME680 sensor. In addition to the BME280 it is able to measure the indoor air quality. Unfortunately the IAQ (Indoor Air Quality) Index calculation algorithm is not publicly available. So we need to live with the gas resistance value which should still be some proxy to the IAQ.
Definitely it would be good if someone can further test the module before it is merged.