Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build when SPIFFS_CACHE==0. #2028

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

jmattsson
Copy link
Member

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

It seems at some point we lost the ability to build if SPIFFS_CACHE is defined to be 0 in user_config.h. The spiffs code bails out due to SPIFFS_CACHE_WR not being defined. This fixes that problem by providing a default definition for it.

@jmattsson jmattsson requested a review from pjsg July 5, 2017 03:39
@jmattsson
Copy link
Member Author

I acknowledge we (DiUS) seem to be the only ones using the filesystem as read-only, so it's probably not worth pushing this issue upstream.

Copy link
Member

@pjsg pjsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible. But I would merge it in -- it might save somebody else.

@marcelstoer marcelstoer added this to the 2.1 follow-up milestone Jul 5, 2017
@marcelstoer marcelstoer merged commit c01f653 into nodemcu:dev Jul 5, 2017
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants