fix #2007 http: Call callback in all cases #2020
Conversation
Call callback with errorcode -1 if no connection could be establioshed
app/http/httpclient.c
Outdated
| return; | ||
| } | ||
| request_args_t * req = (request_args_t *) conn->reverse; | ||
| HTTPCLIENT_ERR( "Calling disconnect" ); |
There was a problem hiding this comment.
Shouldn't this be HTTPCLIENT_DEBUG?
|
Thank you. In #2007 we established that there's also an inconsistency in our documentation wrt the disconnection handling. Can I ask you to clean this up as well in this PR? |
app/http/httpclient.c
Outdated
| return; | ||
| } | ||
| if ( conn->reverse == NULL ) | ||
| { | ||
| HTTPCLIENT_DEBUG( "reverse is NULL" ); |
There was a problem hiding this comment.
It may be helpful to print a more explanatory message. The meaning of "reverse" may not be totally obvious.
There was a problem hiding this comment.
@marcelstoer As to the documentation inconsistency: I am not aware of it, please enlighten me so I can add it.
The fix above establishes the behavior as in the docs AFAICS.
note errorhandling on every call instead of only in the main documentation
|
@marcelstoer Documentation is a good point, already forgot about that problem. But there you go ... |
|
@marcelstoer well I intentionally left out the period as it had been omitted in the other paragraphs as well ;-) |
* fix 2007 Call callback in all cases, call callback with errorcode -1 if no connection could be establioshed * change logging from ERR to DEBUG * make debug output more clear (hopefully) * add handling of errors to docs, note error handling on every call instead of only in the main documentation
Call callback with errorcode -1 if no connection could be establioshed
Fixes #2007 and #1721.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
devbranch rather than formaster.docs/en/*.the PR checks the returnvalue of espconn_(secure_)disconnect. If no connection was established it fails and no disconnected callback is to be expected.
In this case the callback is called directly
I allso added some more error logging which I can remove on request.