Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current version of SPIFFS #1949

Merged
merged 1 commit into from
May 21, 2017
Merged

Conversation

pjsg
Copy link
Member

@pjsg pjsg commented May 1, 2017

Fixes #1515.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).

I ran the update_spiffs.sh command to fetch the latest version of SPIFFS. I had to update the spiffs_config.h for some missing defines.

This builds on my system. Hopefully someone with the original problem can verify this.

@marcelstoer
Copy link
Member

Hopefully someone with the original problem can verify this.

Would be @devsaurus then I guess.

@devsaurus
Copy link
Member

Nack, sorry. I dumped my 32bit system in the meantime.

@FrankX0
Copy link
Contributor

FrankX0 commented May 7, 2017

For what's it worth: I am running 32bit Ubuntu on VirtualBox.
I could recreate the original issue, as described in #1515.
By applying #1949 compile completes without warnings/errors.

@marcelstoer marcelstoer added this to the 2.1 follow-up milestone May 15, 2017
@marcelstoer marcelstoer merged commit e7f0639 into nodemcu:dev May 21, 2017
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants