add ads1115 module #1942
Merged
add ads1115 module #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnc40085
reviewed
Apr 26, 2017
app/modules/ads1115.c
Outdated
|
|
||
| switch (ads1115_samples) { | ||
| case (ADS1115_DR_8SPS): | ||
| os_delay_us(128000); |
There was a problem hiding this comment.
Maybe this should use a timer instead of a delay. A current issue (#1892) is suggesting that we remove all instances of os_delay_us from the code base.
Edit: I shouldn't comment when I'm tired.
From the Extension Developer FAQ:
The Espressif guideline is that no individual task should run for more than 15 mSec, before returning control to the SDK.
Considering this information, it might be better to have the ADC read be asynchronous, so the processor can do other things while waiting for the ADC to return the value.
dnc40085
reviewed
May 6, 2017
docs/en/modules/ads1115.md
Outdated
| * `ads1115.DIFF_1_3` channel 1 to 3 | ||
| * `ads1115.DIFF_2_3` channel 2 to 3 | ||
| - `MODE` Device operating mode | ||
| * `ads1115.SINGLE_SHOT` singel-shot mode |
There was a problem hiding this comment.
Typo. Should be Single-shot.
devsaurus
approved these changes
May 7, 2017
eiselekd
pushed a commit
to eiselekd/nodemcu-firmware
that referenced
this pull request
Jan 7, 2018
* add ads1115 module * replace os_delay with os_timer * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch rather than formaster.docs/en/*.Adds a module for the ADS1115 16-Bit analog-to-digital converter.