Add deprecation message to wifi.sta.config() for argument style cfg #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for the old(argument) style of station configuration was removed in a previous PR, so I added a deprecation message to inform developer of the upcoming removal of the feature.
dnc40085
changed the title
|
Thanks for being so diligent. |
4 tasks
4 tasks
bLandais
added a commit
to bLandais/constellation-documentation
that referenced
this pull request
Nov 6, 2017
Deux modifications dans la partie du code Wifi Lua : 1. La fonction wifi.sta.config() est dépréciée dans le firmware 2.1 (voir nodemcu/nodemcu-firmware#1939 ) 2. Il manquait un end à la fin de la fonction, ce qui bloquait la compilation
eiselekd
pushed a commit
to eiselekd/nodemcu-firmware
that referenced
this pull request
Jan 7, 2018
…nodemcu#1939) Documentation for the old(argument) style of station configuration was removed in a previous PR, so I added a deprecation message to inform developer of the upcoming removal of the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch rather than formaster.The documentation for the old(argument) style of station configuration was removed in a previous PR, but at the time the function
platform_print_deprecation_note()did not exist, so I wasn't able to add a message informing of the removal.Now that the function exists, I decided it was time to add a deprecation message to inform the developer of the upcoming removal the argument style of station configuration.