Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend node.dsleep() to support instant sleep. #1859

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

jmattsson
Copy link
Member

Fixes #1776.

This introduces the "instant" deep sleep feature which Espressif added but largely hid away. See #1776 for further details. Instant deep sleep effectively shaves off ~100ms on the going-to-sleep, which can be quite significant for battery-powered devices.

Due to the lack of documentation, I haven't made the instant deep sleep the default since I don't fully know what the difference between the two deep sleep functions are.

@jmattsson jmattsson added this to the 2.0.0-follow-up milestone Mar 12, 2017
@jmattsson
Copy link
Member Author

Huh! I never knew it was possible to link into a pdf!

And I have no idea how you managed to commit onto my branch? I assume it's some github custom deviltry? :)

Learned something new here - cheers!

@marcelstoer
Copy link
Member

I never knew it was possible to link into a pdf!

That feature has been around for many years (10ish?) but I don't know how widely adopted it's become in browsers and PDF readers/plugins.

I have no idea how you managed to commit onto my branch?

Cool, isn't it! When you create a PR GitHub offers this "Allow edits from maintainers" option (next to the green create-PR button), it's checked by default.

@jmattsson
Copy link
Member Author

Ah, that's what that box does. I figured it was referring to the PR meta-info. Live & learn, eh? :)

@marcelstoer marcelstoer merged commit 45ae795 into nodemcu:dev Mar 14, 2017
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants