TIME_WAIT sockets fixes #1838
TIME_WAIT sockets fixes #1838
Conversation
app/include/lwip/tcp_impl.h
Outdated
| @@ -130,7 +130,7 @@ u32_t tcp_update_rcv_ann_wnd(struct tcp_pcb *pcb)ICACHE_FLASH_ATTR; | |||
| #define TCP_OOSEQ_TIMEOUT 6U /* x RTO */ | |||
|
|
|||
| #ifndef TCP_MSL | |||
| #define TCP_MSL 60000UL /* The maximum segment lifetime in milliseconds */ | |||
| #define TCP_MSL 5000UL /* The maximum segment lifetime in milliseconds */ | |||
There was a problem hiding this comment.
Maybe leave a comment there indicating why this was changed so next time lwIP is updated it shows up in the diff. Can even include a reference to the GitHub issue number. If we don't document such changes there's a real risk that subsequent SDK updates will revert them w/o us noticing.
app/include/lwipopts.h
Outdated
| @@ -1455,7 +1455,7 @@ | |||
| * SO_REUSE==1: Enable SO_REUSEADDR option. | |||
| */ | |||
| #ifndef SO_REUSE | |||
| #define SO_REUSE 0 | |||
| #define SO_REUSE 1 | |||
|
@marcelstoer updated |
|
Rather than make changes inside the lwip includes, which is is really a
deviation of the stock lwip code, why not add external defines for
configuration? The includes say #ifndef blah, #define blah.
…On Mar 7, 2017 9:02 AM, "Yury Popov" ***@***.***> wrote:
@marcelstoer <https://github.com/marcelstoer> updated
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1838 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQC6BkNSerYeVquScczqyw4Yinvx5BN9ks5rjUc2gaJpZM4MU43Q>
.
|
|
@devyte Agree for |
|
Objections here? |
|
No, but since only 2/3 of #1836 are completed I thought you had planned to add more commits to this PR. I now understand you want to create a separate PR at a later point for the 3rd issue, right? |
|
Yep, I think this PR is huge step forward, and I haven't meet Lua GC anyway. So I will try to work on it some later (if nobody finished it earlier). But now these small changes gives big improvements, so I vote for land it as-is. |
* Enable SO_REUSEADDR for server TCP sockets * Reduce TCP_MSL to 5 sec * Add changes notice for future updates * Move MSL change to lwipiots.h
Fixes #1836 (at most)