Add string support for spi.set_mosi() and spi.get_miso() #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean-up endianess handling in spi driver
devsaurus
force-pushed
the
spi_mosi-miso
branch
from
1f6eda8 to
f57ac97
Compare
djphoenix
approved these changes
Feb 1, 2017
eiselekd
pushed a commit
to eiselekd/nodemcu-firmware
that referenced
this pull request
Jan 7, 2018
clean-up endianess handling in spi driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1745.
devbranch rather than formaster.docs/en/*.This PR adds variants of
spi.set_mosi()andspi.get_miso()that accept and return data as string, respectively.Along with the API extension, the endianess handling in the spi driver has been unified.