Dev: added an initial working version of the circular buffer. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you thought of a companion module which is just a wrap-around byte array of variable length records (up to 255 bytes if you wish) with a similar API but you have |
|
👍 on the general idea, but just like my last PR you've done something weird with 70cb01b. This is nothing to do with this PR. You need to remove this. |
The cirbuf module provides a simple, in memory, [circular buffer](https://en.wikipedia.org/wiki/Circular_buffer). This simplifies the design of typical workloads like the sampling of sensors at regular intervals. The memory usage is efficient, apart from ~20 bytes for administration of the circular buffer no additional overhead is required to store the data. signed-off-by: [email protected]
|
Merged the relevant patches, but I don't seem be able to get rid of 70cb01b ... |
The cirbuf module provides a simple, in memory, [circular buffer](https://en.wikipedia.org/wiki/Circular_buffer). This simplifies the design of typical workloads like the sampling of sensors at regular intervals. The memory usage is efficient, apart from ~20 bytes for administration of the circular buffer no additional overhead is required to store the data. signed-off-by: [email protected]
|
Once merged pls update https://github.com/nodemcu/nodemcu-firmware/wiki/Module-list |
|
Fixed stuff in #1062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are welcome.
Here's a link to the API documentation:
https://github.com/hvegh/nodemcu-firmware/blob/dev/docs/en/modules/cirbuf.md