Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Commit

Permalink
Revert of Add debug code to catch faulty interceptor (patchset #1 id:…
Browse files Browse the repository at this point in the history
…1 of https://codereview.chromium.org/2265903002/ )

Reason for revert:
found the culprit

Original issue's description:
> Add debug code to catch faulty interceptor
>
> BUG=chromium:625155
> [email protected]
>
> Committed: https://crrev.com/d181e6e1e6f95ee9c8005a2ad0fc846142dc8aad
> Cr-Commit-Position: refs/heads/master@{#38775}

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:625155

Review-Url: https://codereview.chromium.org/2282663002
Cr-Commit-Position: refs/heads/master@{#38929}
  • Loading branch information
jeisinger authored and Commit bot committed Aug 26, 2016
1 parent f154c75 commit 8d6554b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/objects.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4576,13 +4576,6 @@ Maybe<bool> Object::SetPropertyInternal(LookupIterator* it,
if (result.IsNothing() || result.FromJust()) return result;
// Interceptor modified the store target but failed to set the
// property.
// TODO(jochen): Remove after we've identified the faulty interceptor.
if (!store_target_map.is_null() &&
*store_target_map != it->GetStoreTarget()->map()) {
it->isolate()->PushStackTraceAndDie(
0xabababaa, v8::ToCData<void*>(it->GetInterceptor()->setter()),
nullptr, 0xabababab);
}
Utils::ApiCheck(store_target_map.is_null() ||
*store_target_map == it->GetStoreTarget()->map(),
it->IsElement() ? "v8::IndexedPropertySetterCallback"
Expand Down

0 comments on commit 8d6554b

Please sign in to comment.