Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from size_t to uvwasi_size_t #121

Merged
merged 1 commit into from
May 10, 2020
Merged

migrate from size_t to uvwasi_size_t #121

merged 1 commit into from
May 10, 2020

Conversation

cjihrig
Copy link
Collaborator

@cjihrig cjihrig commented May 10, 2020

This commit defines a 32-bit fixed width uvwasi_size_t, and migrates from size_t to uvwasi_size_t.

Fixes: #119

This commit defines a 32-bit fixed width uvwasi_size_t, and
migrates from size_t to uvwasi_size_t.
@cjihrig cjihrig merged commit c1d9d5a into master May 10, 2020
@cjihrig cjihrig deleted the size branch May 10, 2020 18:14
@sbc100
Copy link
Collaborator

sbc100 commented May 10, 2020

Sweet! Thanks for the quick fix.

I was also wondering if could generate uvwasi/include/wasi_types.h from the witx files, like we do in wasi-libc:
https://github.com/WebAssembly/wasi-libc/blob/master/libc-bottom-half/headers/public/wasi/api.h

That way its alwasy up-to-date and we can include those asserts that the struct layout matches that in the wasm memory too. I'll open another issue that.. and I'm happy out with implementing it if needed.

@cjihrig
Copy link
Collaborator Author

cjihrig commented May 10, 2020

Yes, I'm definitely in favor generating that file - it's just not something I've had the time to get to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of native size_t in the API
2 participants