Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building for externally shared js builtins #2643

Merged
merged 1 commit into from
Jan 28, 2024

Commits on Jan 27, 2024

  1. Support building for externally shared js builtins

    Initial support for loading unbundled module in `AddExternalizedBuiltin`.
    
    - Reduces downstream distribution package size (by not shipping wasm twice
      and not base64-encoding it)
    - Provides a cleaner stacktrace
    - Easier to patch
    
    To enable this, pass `EXTERNAL_PATH=/path/to/global/node_modules/undici`
    to `build/wasm.js`.
    You shall also pass this path to `--shared-builtin-undici/undici-path`
    in Node.js's `configure.py`.
    
    Reference:
    
    nodejs/node@ca5be26b318
    nodejs/node#44376
    
    Signed-off-by: Zephyr Lykos <[email protected]>
    mochaaP committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    fab16f7 View commit details
    Browse the repository at this point in the history