Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SharedArrayBuffer correctly #2466

Merged
merged 10 commits into from
Nov 27, 2023
+15 −5
Merged

fix: handle SharedArrayBuffer correctly #2466

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c477ba
fix: handle SharedArrayBuffer correctly
tsctx Nov 27, 2023
2507129
format
tsctx Nov 27, 2023
9c8ba27
test: add
tsctx Nov 27, 2023
79e8ebb
fix: test
tsctx Nov 27, 2023
4900db7
fixup
tsctx Nov 27, 2023
1bc5e09
use ArrayBuffer.isView
tsctx Nov 27, 2023
0018548
fixup
tsctx Nov 27, 2023
417cc7e
fixup
tsctx Nov 27, 2023
ed31249
test: add Request
tsctx Nov 27, 2023
3d5aac5
fixup
tsctx Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
@tsctx
tsctx committed Nov 27, 2023
commit 3d5aac5c7470c5cb026575ad9aff903d03703be1
4 changes: 2 additions & 2 deletions test/fetch/request.js
View file
Original file line number Diff line number Diff line change
@@ -507,8 +507,8 @@ test('keys to object prototypes method', (t) => {
// https://github.com/nodejs/undici/issues/2465
test('Issue#2465', async (t) => {
t.plan(1)
const response = new Request(new SharedArrayBuffer(0))
t.equal(await response.text(), '[object SharedArrayBuffer]')
const request = new Request('http://localhost', { body: new SharedArrayBuffer(0), method: 'POST' })
t.equal(await request.text(), '[object SharedArrayBuffer]')
})

teardown(() => process.exit())