Drop race condition in connect-timeout test #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
ronag
approved these changes
Oct 19, 2023
KhafraDev
approved these changes
Oct 19, 2023
metcoder95
approved these changes
Oct 19, 2023
kodiakhq bot
referenced
this pull request
in X-oss-byte/Nextjs
Oct 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`5.26.4` -> `5.26.5`](https://renovatebot.com/diffs/npm/undici/5.26.4/5.26.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Oct 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`5.26.4` -> `5.26.5`](https://renovatebot.com/diffs/npm/undici/5.26.4/5.26.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot
referenced
this pull request
in ascorbic/unpic-img
Nov 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`5.25.4` -> `5.27.2`](https://renovatebot.com/diffs/npm/undici/5.25.4/5.27.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.27.2`](https://togithub.com/nodejs/undici/releases/tag/v5.27.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.1...v5.27.2) **Full Changelog**: nodejs/undici@v5.27.1...v5.27.2 ### [`v5.27.1`](https://togithub.com/nodejs/undici/releases/tag/v5.27.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.0...v5.27.1) #### What's Changed - add regression test by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2376](https://togithub.com/nodejs/undici/pull/2376) - fix: define conditions when content-length should be sent by [@​pxue](https://togithub.com/pxue) in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - refactor: removed unnecessary default by [@​nikelborm](https://togithub.com/nikelborm) in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) - fix: stream body handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2391](https://togithub.com/nodejs/undici/pull/2391) #### New Contributors - [@​pxue](https://togithub.com/pxue) made their first contribution in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - [@​nikelborm](https://togithub.com/nikelborm) made their first contribution in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) **Full Changelog**: nodejs/undici@v5.27.0...v5.27.1 ### [`v5.27.0`](https://togithub.com/nodejs/undici/releases/tag/v5.27.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.5...v5.27.0) #### What's Changed - Use sets and reusable TextEncoder/TextDecoder instances by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2368](https://togithub.com/nodejs/undici/pull/2368) - feat: forward onRequestSent to handler by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2375](https://togithub.com/nodejs/undici/pull/2375) - skip bundle test on node 16 by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2377](https://togithub.com/nodejs/undici/pull/2377) - fix windows CI by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2379](https://togithub.com/nodejs/undici/pull/2379) **Full Changelog**: nodejs/undici@v5.26.5...v5.27.0 ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 ### [`v5.26.4`](https://togithub.com/nodejs/undici/releases/tag/v5.26.4) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.3...v5.26.4) #### What's Changed - use esbuild define/hooks by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2342](https://togithub.com/nodejs/undici/pull/2342) - fix request's arrayBuffer returning uint8 instead of arraybuffer by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2344](https://togithub.com/nodejs/undici/pull/2344) - fix: skip readMore call if parser is null or undefined by [@​iiAku](https://togithub.com/iiAku) in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - test: first attempt for flaky fix by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2337](https://togithub.com/nodejs/undici/pull/2337) - test: only include WebSocket in WPT Report where it's landed by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2351](https://togithub.com/nodejs/undici/pull/2351) - Update DispatchInterceptor.md by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - fix: Avoid error for stream() being aborted by [@​BobNobrain](https://togithub.com/BobNobrain) in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) - fix names with esbuild by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2359](https://togithub.com/nodejs/undici/pull/2359) #### New Contributors - [@​iiAku](https://togithub.com/iiAku) made their first contribution in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - [@​Uzlopak](https://togithub.com/Uzlopak) made their first contribution in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - [@​BobNobrain](https://togithub.com/BobNobrain) made their first contribution in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) **Full Changelog**: nodejs/undici@v5.26.3...v5.26.4 ### [`v5.26.3`](https://togithub.com/nodejs/undici/compare/12a62187d45f332cf39dd405f7c52b759cf40cdd...227b9bedf233f741b86dda4ae9d1c7ad69f5d75c) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.2...v5.26.3) ### [`v5.26.2`](https://togithub.com/nodejs/undici/releases/tag/v5.26.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.1...v5.26.2) Security Release, CVE-2023-45143. ### [`v5.26.1`](https://togithub.com/nodejs/undici/releases/tag/v5.26.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.0...v5.26.1) #### What's Changed - Fix publish undici-types once and for all! by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2338](https://togithub.com/nodejs/undici/pull/2338) - Fix node detection omfg by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2341](https://togithub.com/nodejs/undici/pull/2341) **Full Changelog**: nodejs/undici@v5.26.0...v5.26.1 ### [`v5.26.0`](https://togithub.com/nodejs/undici/releases/tag/v5.26.0) [Compare Source](https://togithub.com/nodejs/undici/compare/5e654f351a9a813fed3e9feff4388b5c4fbda787...v5.26.0) #### What's Changed - use npm install instead of npm ci by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2309](https://togithub.com/nodejs/undici/pull/2309) - change default header to `node` by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2310](https://togithub.com/nodejs/undici/pull/2310) - chore: change order of the pseudo-headers by [@​kyrylodolynskyi](https://togithub.com/kyrylodolynskyi) in [https://github.com/nodejs/undici/pull/2308](https://togithub.com/nodejs/undici/pull/2308) - fix: Agent.Options.factory should accept URL object or string as parameter by [@​nicole0707](https://togithub.com/nicole0707) in [https://github.com/nodejs/undici/pull/2295](https://togithub.com/nodejs/undici/pull/2295) - build(deps-dev): bump sinon from 15.2.0 to 16.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2312](https://togithub.com/nodejs/undici/pull/2312) - test: handle npm ignore-scripts settings by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2313](https://togithub.com/nodejs/undici/pull/2313) - feat: respect `--max-http-header-size` Node.js flag by [@​balazsorban44](https://togithub.com/balazsorban44) in [https://github.com/nodejs/undici/pull/2234](https://togithub.com/nodejs/undici/pull/2234) - fix([#​2311](https://togithub.com/nodejs/undici/issues/2311)): End stream after body sent by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2314](https://togithub.com/nodejs/undici/pull/2314) - disallow setting host header in fetch by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2322](https://togithub.com/nodejs/undici/pull/2322) - \[StepSecurity] ci: Harden GitHub Actions by [@​step-security-bot](https://togithub.com/step-security-bot) in [https://github.com/nodejs/undici/pull/2325](https://togithub.com/nodejs/undici/pull/2325) - fix fetch with coverage enabled by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2330](https://togithub.com/nodejs/undici/pull/2330) - Fix stuck when using http2 POST Buffer by [@​binsee](https://togithub.com/binsee) in [https://github.com/nodejs/undici/pull/2336](https://togithub.com/nodejs/undici/pull/2336) - fix: 🏷️ add allowH2 to BuildOptions by [@​binsee](https://togithub.com/binsee) in [https://github.com/nodejs/undici/pull/2334](https://togithub.com/nodejs/undici/pull/2334) - fix: 🐛 fix process http2 header by [@​binsee](https://togithub.com/binsee) in [https://github.com/nodejs/undici/pull/2332](https://togithub.com/nodejs/undici/pull/2332) #### New Contributors - [@​kyrylodolynskyi](https://togithub.com/kyrylodolynskyi) made their first contribution in [https://github.com/nodejs/undici/pull/2308](https://togithub.com/nodejs/undici/pull/2308) - [@​nicole0707](https://togithub.com/nicole0707) made their first contribution in [https://github.com/nodejs/undici/pull/2295](https://togithub.com/nodejs/undici/pull/2295) - [@​balazsorban44](https://togithub.com/balazsorban44) made their first contribution in [https://github.com/nodejs/undici/pull/2234](https://togithub.com/nodejs/undici/pull/2234) - [@​binsee](https://togithub.com/binsee) made their first contribution in [https://github.com/nodejs/undici/pull/2336](https://togithub.com/nodejs/undici/pull/2336) **Full Changelog**: nodejs/undici@v5.23.4...v5.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
renovate bot
referenced
this pull request
in specfy/specfy
Nov 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`5.26.2` -> `5.27.2`](https://renovatebot.com/diffs/npm/undici/5.26.2/5.27.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.27.2`](https://togithub.com/nodejs/undici/releases/tag/v5.27.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.1...v5.27.2) **Full Changelog**: nodejs/undici@v5.27.1...v5.27.2 ### [`v5.27.1`](https://togithub.com/nodejs/undici/releases/tag/v5.27.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.0...v5.27.1) #### What's Changed - add regression test by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2376](https://togithub.com/nodejs/undici/pull/2376) - fix: define conditions when content-length should be sent by [@​pxue](https://togithub.com/pxue) in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - refactor: removed unnecessary default by [@​nikelborm](https://togithub.com/nikelborm) in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) - fix: stream body handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2391](https://togithub.com/nodejs/undici/pull/2391) #### New Contributors - [@​pxue](https://togithub.com/pxue) made their first contribution in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - [@​nikelborm](https://togithub.com/nikelborm) made their first contribution in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) **Full Changelog**: nodejs/undici@v5.27.0...v5.27.1 ### [`v5.27.0`](https://togithub.com/nodejs/undici/releases/tag/v5.27.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.5...v5.27.0) #### What's Changed - Use sets and reusable TextEncoder/TextDecoder instances by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2368](https://togithub.com/nodejs/undici/pull/2368) - feat: forward onRequestSent to handler by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2375](https://togithub.com/nodejs/undici/pull/2375) - skip bundle test on node 16 by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2377](https://togithub.com/nodejs/undici/pull/2377) - fix windows CI by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2379](https://togithub.com/nodejs/undici/pull/2379) **Full Changelog**: nodejs/undici@v5.26.5...v5.27.0 ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 ### [`v5.26.4`](https://togithub.com/nodejs/undici/releases/tag/v5.26.4) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.3...v5.26.4) #### What's Changed - use esbuild define/hooks by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2342](https://togithub.com/nodejs/undici/pull/2342) - fix request's arrayBuffer returning uint8 instead of arraybuffer by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2344](https://togithub.com/nodejs/undici/pull/2344) - fix: skip readMore call if parser is null or undefined by [@​iiAku](https://togithub.com/iiAku) in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - test: first attempt for flaky fix by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2337](https://togithub.com/nodejs/undici/pull/2337) - test: only include WebSocket in WPT Report where it's landed by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2351](https://togithub.com/nodejs/undici/pull/2351) - Update DispatchInterceptor.md by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - fix: Avoid error for stream() being aborted by [@​BobNobrain](https://togithub.com/BobNobrain) in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) - fix names with esbuild by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2359](https://togithub.com/nodejs/undici/pull/2359) #### New Contributors - [@​iiAku](https://togithub.com/iiAku) made their first contribution in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - [@​Uzlopak](https://togithub.com/Uzlopak) made their first contribution in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - [@​BobNobrain](https://togithub.com/BobNobrain) made their first contribution in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) **Full Changelog**: nodejs/undici@v5.26.3...v5.26.4 ### [`v5.26.3`](https://togithub.com/nodejs/undici/compare/12a62187d45f332cf39dd405f7c52b759cf40cdd...227b9bedf233f741b86dda4ae9d1c7ad69f5d75c) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.2...v5.26.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
gr2m
referenced
this pull request
in octokit/rest.js
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`^5.22.1` -> `^6.0.0`](https://renovatebot.com/diffs/npm/undici/5.26.2/6.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v6.0.0`](https://togithub.com/nodejs/undici/releases/tag/v6.0.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.2...v6.0.0) #### What's Changed - 16 eol by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2480](https://togithub.com/nodejs/undici/pull/2480) - update spec & wpts by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2482](https://togithub.com/nodejs/undici/pull/2482) - version cleanup by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2483](https://togithub.com/nodejs/undici/pull/2483) - perf: avoid Response initialization by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2489](https://togithub.com/nodejs/undici/pull/2489) - perf: optimize `parseHeaders` by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2492](https://togithub.com/nodejs/undici/pull/2492) - chore: fix typo by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2490](https://togithub.com/nodejs/undici/pull/2490) - feat: print attempted addresses on ConnectTimeoutError by [@​fengmk2](https://togithub.com/fengmk2) in [https://github.com/nodejs/undici/pull/2494](https://togithub.com/nodejs/undici/pull/2494) - Expose HTTP errors that are not meant to be retried by [@​MzUgM](https://togithub.com/MzUgM) in [https://github.com/nodejs/undici/pull/2496](https://togithub.com/nodejs/undici/pull/2496) **Full Changelog**: nodejs/undici@v5.28.2...v6.0.0 ### [`v5.28.2`](https://togithub.com/nodejs/undici/releases/tag/v5.28.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.1...v5.28.2) #### What's Changed - fix: remove optional chainning for compatible with Nodejs12 and below by [@​bugb](https://togithub.com/bugb) in [https://github.com/nodejs/undici/pull/2470](https://togithub.com/nodejs/undici/pull/2470) - fix: remove `node:` prefix by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2471](https://togithub.com/nodejs/undici/pull/2471) - perf: avoid Headers initialization by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2468](https://togithub.com/nodejs/undici/pull/2468) - fix: handle SharedArrayBuffer correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2466](https://togithub.com/nodejs/undici/pull/2466) - fix: Add `null` type to `signal` in `RequestInit` by [@​gebsh](https://togithub.com/gebsh) in [https://github.com/nodejs/undici/pull/2455](https://togithub.com/nodejs/undici/pull/2455) - fix: correctly handle data URL with hashes. by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2475](https://togithub.com/nodejs/undici/pull/2475) - fix: check response for timinginfo allow flag by [@​ToshB](https://togithub.com/ToshB) in [https://github.com/nodejs/undici/pull/2477](https://togithub.com/nodejs/undici/pull/2477) - Make call to onBodySent conditional in RetryHandler by [@​MzUgM](https://togithub.com/MzUgM) in [https://github.com/nodejs/undici/pull/2478](https://togithub.com/nodejs/undici/pull/2478) - refactor: better integrity check by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2462](https://togithub.com/nodejs/undici/pull/2462) - fix: Added support for inline URL username:password proxy auth by [@​matt-way](https://togithub.com/matt-way) in [https://github.com/nodejs/undici/pull/2473](https://togithub.com/nodejs/undici/pull/2473) - build(deps-dev): bump jsdom from 22.1.0 to 23.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2472](https://togithub.com/nodejs/undici/pull/2472) - build(deps-dev): bump sinon from 16.1.3 to 17.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2405](https://togithub.com/nodejs/undici/pull/2405) - build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2396](https://togithub.com/nodejs/undici/pull/2396) - build(deps): bump actions/setup-node from 3.8.1 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2395](https://togithub.com/nodejs/undici/pull/2395) - build(deps): bump step-security/harden-runner from 2.5.0 to 2.6.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2392](https://togithub.com/nodejs/undici/pull/2392) - build(deps-dev): bump formdata-node from 4.4.1 to 6.0.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2389](https://togithub.com/nodejs/undici/pull/2389) - build(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2302](https://togithub.com/nodejs/undici/pull/2302) #### New Contributors - [@​bugb](https://togithub.com/bugb) made their first contribution in [https://github.com/nodejs/undici/pull/2470](https://togithub.com/nodejs/undici/pull/2470) - [@​gebsh](https://togithub.com/gebsh) made their first contribution in [https://github.com/nodejs/undici/pull/2455](https://togithub.com/nodejs/undici/pull/2455) - [@​ToshB](https://togithub.com/ToshB) made their first contribution in [https://github.com/nodejs/undici/pull/2477](https://togithub.com/nodejs/undici/pull/2477) - [@​MzUgM](https://togithub.com/MzUgM) made their first contribution in [https://github.com/nodejs/undici/pull/2478](https://togithub.com/nodejs/undici/pull/2478) - [@​matt-way](https://togithub.com/matt-way) made their first contribution in [https://github.com/nodejs/undici/pull/2473](https://togithub.com/nodejs/undici/pull/2473) **Full Changelog**: nodejs/undici@v5.28.1...v5.28.2 ### [`v5.28.1`](https://togithub.com/nodejs/undici/releases/tag/v5.28.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.0...v5.28.1) #### What's Changed - perf: Improve `normalizeMethod` by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2456](https://togithub.com/nodejs/undici/pull/2456) - fix: dispatch error handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2459](https://togithub.com/nodejs/undici/pull/2459) - perf(request): optimize if headers are given by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2454](https://togithub.com/nodejs/undici/pull/2454) **Full Changelog**: nodejs/undici@v5.28.0...v5.28.1 ### [`v5.28.0`](https://togithub.com/nodejs/undici/releases/tag/v5.28.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.2...v5.28.0) #### What's Changed - fix(parseHeaders): util.parseHeaders handle correctly array of buffer… by [@​mdoria12](https://togithub.com/mdoria12) in [https://github.com/nodejs/undici/pull/2398](https://togithub.com/nodejs/undici/pull/2398) - docs: add license to undici-types by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/nodejs/undici/pull/2401](https://togithub.com/nodejs/undici/pull/2401) - perf: optimize Readable.dump by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2402](https://togithub.com/nodejs/undici/pull/2402) - perf(headers): Improve Headers by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2397](https://togithub.com/nodejs/undici/pull/2397) - test: re-enable conditional WPT Report for websockets by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2407](https://togithub.com/nodejs/undici/pull/2407) - fix: delay abort on 'close' by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2408](https://togithub.com/nodejs/undici/pull/2408) - refactor: use `substring` instead of `substr` by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2411](https://togithub.com/nodejs/undici/pull/2411) - add additional http2 test with fetch by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2419](https://togithub.com/nodejs/undici/pull/2419) - fix: HTTPToken check by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2410](https://togithub.com/nodejs/undici/pull/2410) - perf: optimize HeadersList.get by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2420](https://togithub.com/nodejs/undici/pull/2420) - properly handle pseudo-headers in fetch by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2422](https://togithub.com/nodejs/undici/pull/2422) - perf(headers): if the guard is immutable by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2424](https://togithub.com/nodejs/undici/pull/2424) - fix(mock-agent): send stream body by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2425](https://togithub.com/nodejs/undici/pull/2425) - build(deps): bump github/codeql-action from 2.21.5 to 2.22.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2394](https://togithub.com/nodejs/undici/pull/2394) - feat([#​2264](https://togithub.com/nodejs/undici/issues/2264)): Expose Retry Handler by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2281](https://togithub.com/nodejs/undici/pull/2281) - fix: implement `Headers#set` correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2432](https://togithub.com/nodejs/undici/pull/2432) - fix: implement `Headers#delete` correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2430](https://togithub.com/nodejs/undici/pull/2430) - test: update websocket wpt availability by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2437](https://togithub.com/nodejs/undici/pull/2437) - fix: type comment position by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2443](https://togithub.com/nodejs/undici/pull/2443) - fix: `onHeaders` type declaration by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2444](https://togithub.com/nodejs/undici/pull/2444) - remove http2 status pseudo header from headers by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2438](https://togithub.com/nodejs/undici/pull/2438) - docs: Clarify `path` matching in `intercept()` by [@​oliversalzburg](https://togithub.com/oliversalzburg) in [https://github.com/nodejs/undici/pull/2426](https://togithub.com/nodejs/undici/pull/2426) - fix: set-cookie clone by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2446](https://togithub.com/nodejs/undici/pull/2446) - docs: fix typo in maxConcurrentStreams by [@​tniessen](https://togithub.com/tniessen) in [https://github.com/nodejs/undici/pull/2450](https://togithub.com/nodejs/undici/pull/2450) - refactor: remove leftovers by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2451](https://togithub.com/nodejs/undici/pull/2451) - refactor: add missing new operator by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2452](https://togithub.com/nodejs/undici/pull/2452) #### New Contributors - [@​mdoria12](https://togithub.com/mdoria12) made their first contribution in [https://github.com/nodejs/undici/pull/2398](https://togithub.com/nodejs/undici/pull/2398) - [@​tsctx](https://togithub.com/tsctx) made their first contribution in [https://github.com/nodejs/undici/pull/2397](https://togithub.com/nodejs/undici/pull/2397) - [@​oliversalzburg](https://togithub.com/oliversalzburg) made their first contribution in [https://github.com/nodejs/undici/pull/2426](https://togithub.com/nodejs/undici/pull/2426) **Full Changelog**: nodejs/undici@v5.27.2...v5.28.0 ### [`v5.27.2`](https://togithub.com/nodejs/undici/releases/tag/v5.27.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.1...v5.27.2) **Full Changelog**: nodejs/undici@v5.27.1...v5.27.2 ### [`v5.27.1`](https://togithub.com/nodejs/undici/releases/tag/v5.27.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.0...v5.27.1) #### What's Changed - add regression test by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2376](https://togithub.com/nodejs/undici/pull/2376) - fix: define conditions when content-length should be sent by [@​pxue](https://togithub.com/pxue) in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - refactor: removed unnecessary default by [@​nikelborm](https://togithub.com/nikelborm) in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) - fix: stream body handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2391](https://togithub.com/nodejs/undici/pull/2391) #### New Contributors - [@​pxue](https://togithub.com/pxue) made their first contribution in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - [@​nikelborm](https://togithub.com/nikelborm) made their first contribution in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) **Full Changelog**: nodejs/undici@v5.27.0...v5.27.1 ### [`v5.27.0`](https://togithub.com/nodejs/undici/releases/tag/v5.27.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.5...v5.27.0) #### What's Changed - Use sets and reusable TextEncoder/TextDecoder instances by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2368](https://togithub.com/nodejs/undici/pull/2368) - feat: forward onRequestSent to handler by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2375](https://togithub.com/nodejs/undici/pull/2375) - skip bundle test on node 16 by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2377](https://togithub.com/nodejs/undici/pull/2377) - fix windows CI by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2379](https://togithub.com/nodejs/undici/pull/2379) **Full Changelog**: nodejs/undici@v5.26.5...v5.27.0 ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 ### [`v5.26.4`](https://togithub.com/nodejs/undici/releases/tag/v5.26.4) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.3...v5.26.4) #### What's Changed - use esbuild define/hooks by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2342](https://togithub.com/nodejs/undici/pull/2342) - fix request's arrayBuffer returning uint8 instead of arraybuffer by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2344](https://togithub.com/nodejs/undici/pull/2344) - fix: skip readMore call if parser is null or undefined by [@​iiAku](https://togithub.com/iiAku) in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - test: first attempt for flaky fix by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2337](https://togithub.com/nodejs/undici/pull/2337) - test: only include WebSocket in WPT Report where it's landed by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2351](https://togithub.com/nodejs/undici/pull/2351) - Update DispatchInterceptor.md by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - fix: Avoid error for stream() being aborted by [@​BobNobrain](https://togithub.com/BobNobrain) in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) - fix names with esbuild by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2359](https://togithub.com/nodejs/undici/pull/2359) #### New Contributors - [@​iiAku](https://togithub.com/iiAku) made their first contribution in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - [@​Uzlopak](https://togithub.com/Uzlopak) made their first contribution in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - [@​BobNobrain](https://togithub.com/BobNobrain) made their first contribution in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) **Full Changelog**: nodejs/undici@v5.26.3...v5.26.4 ### [`v5.26.3`](https://togithub.com/nodejs/undici/compare/12a62187d45f332cf39dd405f7c52b759cf40cdd...227b9bedf233f741b86dda4ae9d1c7ad69f5d75c) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.2...v5.26.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/octokit/rest.js). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
louis-bompart
referenced
this pull request
in coveo/cli
Feb 21, 2024
…#1428) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`5.26.2` -> `5.28.3`](https://renovatebot.com/diffs/npm/undici/5.26.2/5.28.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-24758](https://togithub.com/nodejs/undici/security/advisories/GHSA-3787-6prv-h9w3) ### Impact Undici already cleared Authorization headers on cross-origin redirects, but did not clear `Proxy-Authorization` headers. ### Patches This is patched in v5.28.3 and v6.6.1 ### Workarounds There are no known workarounds. ### References - https://fetch.spec.whatwg.org/#authentication-entries - GHSA-wqq4-5wpv-mx2g --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.28.3`](https://togithub.com/nodejs/undici/releases/tag/v5.28.3) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.2...v5.28.3) ####⚠️ Security Release⚠️ Details on the vulnerabilities fixed will be shared in the next couple of days. **Full Changelog**: nodejs/undici@v5.28.2...v5.28.3 ### [`v5.28.2`](https://togithub.com/nodejs/undici/releases/tag/v5.28.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.1...v5.28.2) #### What's Changed - fix: remove optional chainning for compatible with Nodejs12 and below by [@​bugb](https://togithub.com/bugb) in [https://github.com/nodejs/undici/pull/2470](https://togithub.com/nodejs/undici/pull/2470) - fix: remove `node:` prefix by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2471](https://togithub.com/nodejs/undici/pull/2471) - perf: avoid Headers initialization by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2468](https://togithub.com/nodejs/undici/pull/2468) - fix: handle SharedArrayBuffer correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2466](https://togithub.com/nodejs/undici/pull/2466) - fix: Add `null` type to `signal` in `RequestInit` by [@​gebsh](https://togithub.com/gebsh) in [https://github.com/nodejs/undici/pull/2455](https://togithub.com/nodejs/undici/pull/2455) - fix: correctly handle data URL with hashes. by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2475](https://togithub.com/nodejs/undici/pull/2475) - fix: check response for timinginfo allow flag by [@​ToshB](https://togithub.com/ToshB) in [https://github.com/nodejs/undici/pull/2477](https://togithub.com/nodejs/undici/pull/2477) - Make call to onBodySent conditional in RetryHandler by [@​MzUgM](https://togithub.com/MzUgM) in [https://github.com/nodejs/undici/pull/2478](https://togithub.com/nodejs/undici/pull/2478) - refactor: better integrity check by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2462](https://togithub.com/nodejs/undici/pull/2462) - fix: Added support for inline URL username:password proxy auth by [@​matt-way](https://togithub.com/matt-way) in [https://github.com/nodejs/undici/pull/2473](https://togithub.com/nodejs/undici/pull/2473) - build(deps-dev): bump jsdom from 22.1.0 to 23.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2472](https://togithub.com/nodejs/undici/pull/2472) - build(deps-dev): bump sinon from 16.1.3 to 17.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2405](https://togithub.com/nodejs/undici/pull/2405) - build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2396](https://togithub.com/nodejs/undici/pull/2396) - build(deps): bump actions/setup-node from 3.8.1 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2395](https://togithub.com/nodejs/undici/pull/2395) - build(deps): bump step-security/harden-runner from 2.5.0 to 2.6.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2392](https://togithub.com/nodejs/undici/pull/2392) - build(deps-dev): bump formdata-node from 4.4.1 to 6.0.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2389](https://togithub.com/nodejs/undici/pull/2389) - build(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2302](https://togithub.com/nodejs/undici/pull/2302) #### New Contributors - [@​bugb](https://togithub.com/bugb) made their first contribution in [https://github.com/nodejs/undici/pull/2470](https://togithub.com/nodejs/undici/pull/2470) - [@​gebsh](https://togithub.com/gebsh) made their first contribution in [https://github.com/nodejs/undici/pull/2455](https://togithub.com/nodejs/undici/pull/2455) - [@​ToshB](https://togithub.com/ToshB) made their first contribution in [https://github.com/nodejs/undici/pull/2477](https://togithub.com/nodejs/undici/pull/2477) - [@​MzUgM](https://togithub.com/MzUgM) made their first contribution in [https://github.com/nodejs/undici/pull/2478](https://togithub.com/nodejs/undici/pull/2478) - [@​matt-way](https://togithub.com/matt-way) made their first contribution in [https://github.com/nodejs/undici/pull/2473](https://togithub.com/nodejs/undici/pull/2473) **Full Changelog**: nodejs/undici@v5.28.1...v5.28.2 ### [`v5.28.1`](https://togithub.com/nodejs/undici/releases/tag/v5.28.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.28.0...v5.28.1) #### What's Changed - perf: Improve `normalizeMethod` by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2456](https://togithub.com/nodejs/undici/pull/2456) - fix: dispatch error handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2459](https://togithub.com/nodejs/undici/pull/2459) - perf(request): optimize if headers are given by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2454](https://togithub.com/nodejs/undici/pull/2454) **Full Changelog**: nodejs/undici@v5.28.0...v5.28.1 ### [`v5.28.0`](https://togithub.com/nodejs/undici/releases/tag/v5.28.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.2...v5.28.0) #### What's Changed - fix(parseHeaders): util.parseHeaders handle correctly array of buffer… by [@​mdoria12](https://togithub.com/mdoria12) in [https://github.com/nodejs/undici/pull/2398](https://togithub.com/nodejs/undici/pull/2398) - docs: add license to undici-types by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/nodejs/undici/pull/2401](https://togithub.com/nodejs/undici/pull/2401) - perf: optimize Readable.dump by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2402](https://togithub.com/nodejs/undici/pull/2402) - perf(headers): Improve Headers by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2397](https://togithub.com/nodejs/undici/pull/2397) - test: re-enable conditional WPT Report for websockets by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2407](https://togithub.com/nodejs/undici/pull/2407) - fix: delay abort on 'close' by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2408](https://togithub.com/nodejs/undici/pull/2408) - refactor: use `substring` instead of `substr` by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2411](https://togithub.com/nodejs/undici/pull/2411) - add additional http2 test with fetch by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2419](https://togithub.com/nodejs/undici/pull/2419) - fix: HTTPToken check by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2410](https://togithub.com/nodejs/undici/pull/2410) - perf: optimize HeadersList.get by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2420](https://togithub.com/nodejs/undici/pull/2420) - properly handle pseudo-headers in fetch by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2422](https://togithub.com/nodejs/undici/pull/2422) - perf(headers): if the guard is immutable by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2424](https://togithub.com/nodejs/undici/pull/2424) - fix(mock-agent): send stream body by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2425](https://togithub.com/nodejs/undici/pull/2425) - build(deps): bump github/codeql-action from 2.21.5 to 2.22.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2394](https://togithub.com/nodejs/undici/pull/2394) - feat([#​2264](https://togithub.com/nodejs/undici/issues/2264)): Expose Retry Handler by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2281](https://togithub.com/nodejs/undici/pull/2281) - fix: implement `Headers#set` correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2432](https://togithub.com/nodejs/undici/pull/2432) - fix: implement `Headers#delete` correctly by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2430](https://togithub.com/nodejs/undici/pull/2430) - test: update websocket wpt availability by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2437](https://togithub.com/nodejs/undici/pull/2437) - fix: type comment position by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2443](https://togithub.com/nodejs/undici/pull/2443) - fix: `onHeaders` type declaration by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2444](https://togithub.com/nodejs/undici/pull/2444) - remove http2 status pseudo header from headers by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2438](https://togithub.com/nodejs/undici/pull/2438) - docs: Clarify `path` matching in `intercept()` by [@​oliversalzburg](https://togithub.com/oliversalzburg) in [https://github.com/nodejs/undici/pull/2426](https://togithub.com/nodejs/undici/pull/2426) - fix: set-cookie clone by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2446](https://togithub.com/nodejs/undici/pull/2446) - docs: fix typo in maxConcurrentStreams by [@​tniessen](https://togithub.com/tniessen) in [https://github.com/nodejs/undici/pull/2450](https://togithub.com/nodejs/undici/pull/2450) - refactor: remove leftovers by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2451](https://togithub.com/nodejs/undici/pull/2451) - refactor: add missing new operator by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2452](https://togithub.com/nodejs/undici/pull/2452) #### New Contributors - [@​mdoria12](https://togithub.com/mdoria12) made their first contribution in [https://github.com/nodejs/undici/pull/2398](https://togithub.com/nodejs/undici/pull/2398) - [@​tsctx](https://togithub.com/tsctx) made their first contribution in [https://github.com/nodejs/undici/pull/2397](https://togithub.com/nodejs/undici/pull/2397) - [@​oliversalzburg](https://togithub.com/oliversalzburg) made their first contribution in [https://github.com/nodejs/undici/pull/2426](https://togithub.com/nodejs/undici/pull/2426) **Full Changelog**: nodejs/undici@v5.27.2...v5.28.0 ### [`v5.27.2`](https://togithub.com/nodejs/undici/releases/tag/v5.27.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.1...v5.27.2) **Full Changelog**: nodejs/undici@v5.27.1...v5.27.2 ### [`v5.27.1`](https://togithub.com/nodejs/undici/releases/tag/v5.27.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.27.0...v5.27.1) #### What's Changed - add regression test by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2376](https://togithub.com/nodejs/undici/pull/2376) - fix: define conditions when content-length should be sent by [@​pxue](https://togithub.com/pxue) in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - refactor: removed unnecessary default by [@​nikelborm](https://togithub.com/nikelborm) in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) - fix: stream body handling by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2391](https://togithub.com/nodejs/undici/pull/2391) #### New Contributors - [@​pxue](https://togithub.com/pxue) made their first contribution in [https://github.com/nodejs/undici/pull/2305](https://togithub.com/nodejs/undici/pull/2305) - [@​nikelborm](https://togithub.com/nikelborm) made their first contribution in [https://github.com/nodejs/undici/pull/2381](https://togithub.com/nodejs/undici/pull/2381) **Full Changelog**: nodejs/undici@v5.27.0...v5.27.1 ### [`v5.27.0`](https://togithub.com/nodejs/undici/releases/tag/v5.27.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.5...v5.27.0) #### What's Changed - Use sets and reusable TextEncoder/TextDecoder instances by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2368](https://togithub.com/nodejs/undici/pull/2368) - feat: forward onRequestSent to handler by [@​ronag](https://togithub.com/ronag) in [https://github.com/nodejs/undici/pull/2375](https://togithub.com/nodejs/undici/pull/2375) - skip bundle test on node 16 by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2377](https://togithub.com/nodejs/undici/pull/2377) - fix windows CI by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2379](https://togithub.com/nodejs/undici/pull/2379) **Full Changelog**: nodejs/undici@v5.26.5...v5.27.0 ### [`v5.26.5`](https://togithub.com/nodejs/undici/releases/tag/v5.26.5) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.4...v5.26.5) #### What's Changed - Drop race condition in connect-timeout test by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2360](https://togithub.com/nodejs/undici/pull/2360) - Remove a couple of unnecessary async functions by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/nodejs/undici/pull/2367](https://togithub.com/nodejs/undici/pull/2367) - Update namespace type with Fetch exports by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2361](https://togithub.com/nodejs/undici/pull/2361) **Full Changelog**: nodejs/undici@v5.26.4...v5.26.5 ### [`v5.26.4`](https://togithub.com/nodejs/undici/releases/tag/v5.26.4) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.3...v5.26.4) #### What's Changed - use esbuild define/hooks by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2342](https://togithub.com/nodejs/undici/pull/2342) - fix request's arrayBuffer returning uint8 instead of arraybuffer by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2344](https://togithub.com/nodejs/undici/pull/2344) - fix: skip readMore call if parser is null or undefined by [@​iiAku](https://togithub.com/iiAku) in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - test: first attempt for flaky fix by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/nodejs/undici/pull/2337](https://togithub.com/nodejs/undici/pull/2337) - test: only include WebSocket in WPT Report where it's landed by [@​panva](https://togithub.com/panva) in [https://github.com/nodejs/undici/pull/2351](https://togithub.com/nodejs/undici/pull/2351) - Update DispatchInterceptor.md by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - fix: Avoid error for stream() being aborted by [@​BobNobrain](https://togithub.com/BobNobrain) in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) - fix names with esbuild by [@​KhafraDev](https://togithub.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2359](https://togithub.com/nodejs/undici/pull/2359) #### New Contributors - [@​iiAku](https://togithub.com/iiAku) made their first contribution in [https://github.com/nodejs/undici/pull/2346](https://togithub.com/nodejs/undici/pull/2346) - [@​Uzlopak](https://togithub.com/Uzlopak) made their first contribution in [https://github.com/nodejs/undici/pull/2354](https://togithub.com/nodejs/undici/pull/2354) - [@​BobNobrain](https://togithub.com/BobNobrain) made their first contribution in [https://github.com/nodejs/undici/pull/2355](https://togithub.com/nodejs/undici/pull/2355) **Full Changelog**: nodejs/undici@v5.26.3...v5.26.4 ### [`v5.26.3`](https://togithub.com/nodejs/undici/compare/12a62187d45f332cf39dd405f7c52b759cf40cdd...227b9bedf233f741b86dda4ae9d1c7ad69f5d75c) [Compare Source](https://togithub.com/nodejs/undici/compare/v5.26.2...v5.26.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/coveo/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
](https://renovatebot.com){kind=link}
Signed-off-by: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nodejs/citgm#982 (comment)