fix: request.pipeline edgecases #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will follow up at some point with a version where the |
ronag
force-pushed
the
pipeline-edge
branch
9 times, most recently
from
e0f41db to
2337d75
Compare
ronag
commented
May 30, 2020
| // TODO: The callback might not be invoked | ||
| // on error in pre Node 14. | ||
| // TODO: The callback might not correspond | ||
| // to a successful flush of the socket. |
There was a problem hiding this comment.
These notes probably don't have much if any impact in practical usage. But it might not strictly follow the expected API contract.
There was a problem hiding this comment.
Will require some further work (#208) to fully resolve but I don't think this is a blocker for release.
mcollina
reviewed
May 30, 2020
| @@ -88,17 +86,15 @@ class Client extends ClientBase { | |||
| return new PassThrough().destroy(new InvalidArgumentError('invalid handler')) | |||
| } | |||
|
|
|||
| let req = new Readable({ | |||
| // TODO: Let ret write directly to socket without intermediate. | |||
| const req = new PassThrough({ | |||
There was a problem hiding this comment.
This should really be a Readable. Otherwise it’s costing us dearly.
There was a problem hiding this comment.
Ok. I'll give it another try.
The optimizated verison of request.pipeline had some hard to determine edge cases. Reverting back to non-optimized version until a better solution can be implemented. Fixes: #206
|
Fixed through c553ba1 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizated verison of request.pipeline had some hard
to determine edge cases. Reverting back to non-optimized
version until a better solution can be implemented.
Fixes: #206