fetch: fix leak

[ronag]

Fixes: #1823
Fixes: nodejs/node#46435

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 🎉

Comparison is base (f0271d4) 90.45% compared to head (f46f5cc) 90.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   90.45%   90.59%   +0.13%     
==========================================
  Files          71       71              
  Lines        6174     6366     +192     
==========================================
+ Hits         5585     5767     +182     
- Misses        589      599      +10     

Impacted Files	Coverage Δ
lib/fetch/request.js	89.12% <100.00%> (+1.08%)	⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ronag]

@mcollina now with a test

[mcollina]

CI seems to be failing badly :(.

[ronag]

@mcollina Do you have any idea how to do this better?

[stalkerg]

it's smart! I think it's better than nothing.

[ronag]

@mcollina PTAL

[mcollina]

lgtm

are the v19 failures related? We need to sort those too.

[KhafraDev]

test failures are from #2020

[KhafraDev]

Just got this failure on the windows v19 ci:

# Subtest: test/fetch/fetch-leak.js
    # Subtest: do not leak
        1..1
        ok 1 - (unnamed test)
    ok 1 - do not leak # time=1071.239ms
    
    not ok 2 - fetch failed
      ---
      at:
        line: 1
        column: 17427
        file: index.js
        function: fetch
      stack: |
        fetch (index.js:1:17427)
      type: TypeError
      cause:
        !error
        name: Error
        message: read ECONNRESET
        stack: |-
          Error: read ECONNRESET
              at TCP.onStreamRead (node:internal/stream_base_commons:217:20)
        errno: -4077
        code: ECONNRESET
        syscall: read
      tapCaught: unhandledRejection
      test: TAP
      source: "'use strict'\r
      
        \r
      
        const Client = require('./lib/client')\n"
      ...
    
    1..2
    # failed 1 of 2 tests
    # time=1112.355ms
not ok 12 - test/fetch/fetch-leak.js # time=1112.355ms