Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: husky install is deprecated #3339

Closed
jazelly opened this issue Jun 18, 2024 · 1 comment
Closed

build: husky install is deprecated #3339

jazelly opened this issue Jun 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jazelly
Copy link
Member

jazelly commented Jun 18, 2024

This would solve...

The deprecation warning sent from husky, introduced from husky v9.0.1

The implementation should look like...

Simply remove install as suggested

Additional context

This is what you get currently

npm i

> [email protected] prepare
> husky install && node ./scripts/platform-shell.js

install command is deprecated

up to date, audited 748 packages in 1s

174 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
@jazelly jazelly added the enhancement New feature or request label Jun 18, 2024
jazelly added a commit to jazelly/undici that referenced this issue Jun 18, 2024
@jazelly
build: use husky as husky install is deprecated
40e2ef4 
Refs: nodejs#3339
@jazelly jazelly mentioned this issue Jun 18, 2024
Merged
7 tasks
@jazelly
Copy link
Member Author

jazelly commented Jun 18, 2024

Completed with #3340

@jazelly jazelly closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jazelly