Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for August 8th, 2017 #38

Closed
wants to merge 4 commits into from
Closed

doc: add minutes for August 8th, 2017 #38

wants to merge 4 commits into from

Conversation

sam-github
Copy link
Contributor

close #32

Copy link
Contributor Author

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedloden, perhaps you can answer some questions I had about rubysec, I forgot to ask in the demo!

- Github: https://github.com/rubysec/ruby-advisory-db
- Stores vuln per file, covers both gems (`gems/`) and ruby runtimes (`rubies`)
- Every vuln has a CVE or a OSVDB, but the OSF (open security foundation) has
closed shop, and all the OSVDB links are now dead
Copy link
Contributor Author

@sam-github sam-github Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedloden this was unfortunate, is there a back story? This shouldn't happen to us if we use mitre-allocated CVEs, I hope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://blog.osvdb.org/2016/04/05/osvdb-fin/ and http://www.securityweek.com/osvdb-shut-down-permanently talk about it somewhat, but the TL;DR is that the majority of the work was being done by Risk Based Security (with very little input from the community), and then others were scraping the site and taking the content for themselves without paying for it or contributing back. So, frankly, just didn't make financial sense for them to keep running the site. :(

This has no impact on CVE allocation at all. One of the big reasons why RubySec used OSVDB for a long time is because it was so hard to get CVEs from MITRE. Nowadays, with more and more companies being CNAs, that isn't a problem anymore. CNAs receive a block of CVEs from MITRE, so they can just assign on-demand.

2. Npmjs.org package vulnerabilities

For npmjs.org packages, HackerOne looks to have a great feature set, CVE
issuance and the rich permission model among them.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson this should interest you in particular

- Vulns can be submitted via PR, or a form (https://rubysec.com/advisories/new),
but there isn’t any information on what the disclosure policy is. The form
suggests to me that they expect to see only reports for issues that are already
publically known and reported to the gem authors (and possibly already fixed).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedloden is this true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, RubySec mostly dealt with tracking existing vulnerabilities that were already fixed (or at least widely-known). Rarely did we ever act as a middle-man with disclosing issues to specific gems, mostly because we would just point people to http://guides.rubygems.org/security/#reporting-security-vulnerabilities (which, now that I read it, is outdated). However, in the Node.js world, I know that NSP has actively acted as that middle-man, which is fine, but it does require coordination work on somebody's part to reach out to the appropriate module author and get issues fixed.

- Has a website: https://rubysec.com/, from which you can get Atom updates of
vulns, browse the DB using a web UI, report vulnerabilities, and it also points
to the bundler audit utility.
- No information on policies or procedures that I found.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedloden I was looking for information on when vulns would be published, specifically, how gem authors are notified, how long they are given to respond to reports, things like that. Can you elaborate on your experience with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, we generally only deal(t) with already fixed issues, just getting them categorized and publicized so that people would know to update their applications to use the fixed versions. As such, I'm not aware of any set policies/procedures on handling of disclosure. In those rare cases where RubySec did deal with something, we would generally just reach out to the affected gem authors and notify them privately, working with them on getting an issue fixed, and then getting it publicized in ruby-advisory-db so that people knew to update.

the Node Security Response Team, Ben and Fyodor at least. The thing they might
find most compelling for use with node core relates to permissions, since the
Response team size has been described as too large recently. Use of HackerOne
will allow:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: #17 (comment), these are the features that I think will be most interesting to @nodejs/security

- Josh Brown-White (@joshbw)
- Colin Ihrig (@cjihrig)
- Reed Loden (@reedloden)
- Deian Stefan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-github
Copy link
Contributor Author

@joshbw @cjihrig @reedloden @deian @michiel3 @bengl @drifkin PTAL, needs some LGTMs

# Security WG meeting 2017-08-10

GitHub issue: https://github.com/nodejs/security-wg/issues/32
Meeting video: TBA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A, since we didn't record?



I’d like to see some investigation of the API to ensure we can pull issues out
as JSON for storage in github.com, but otherwise I think we should try it out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that GitHub's security team uses our API to pull content in order to display on https://bounty.github.com/, so it's definitely possible. :)

[x] Sam: will PR a description of what Node.js considers a security issue (https://github.com/nodejs/security-wg/issues/18) See https://github.com/nodejs/node/pull/14485
[x] JoshBW: will evaluate HackerOne and BugCrowd (https://github.com/nodejs/security-wg/issues/16, https://github.com/nodejs/security-wg/issues/17)
[x] JoshBW: will investigate what it takes to get a semmle.com license for Node.js as an open source project (https://github.com/nodejs/security-wg/issues/29)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I use 'view" this does not show up as expected, its just on big long line. I think you are missing a "- " in front of the options.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

Landed in b81ba11

@sam-github sam-github closed this Sep 11, 2017
@sam-github sam-github deleted the meeting-2017-08-10 branch September 11, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security WG meeting 2017-08-10
6 participants