Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caret during installation #268

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Avoid caret during installation #268

merged 1 commit into from
Apr 7, 2017

Conversation

mcollina
Copy link
Member

For some context, I would like mysql to use the latest readable-stream: mysqljs/mysql#1677

@calvinmetcalf
Copy link
Contributor

dependencies of dependencies are also an issue, which is why I did it this way

@mcollina mcollina force-pushed the avoid-caret branch 2 times, most recently from 61d2b71 to 79a1c0c Compare March 29, 2017 08:33
This restores support for older versions of NPM.
@mcollina
Copy link
Member Author

Updated, this should work also on older versions of NPM.

@mcollina
Copy link
Member Author

@calvinmetcalf yes. But it might allow the mysql module to upgrade to v2. We don't expect buffer-shims to change at any point in time either.

@mcollina mcollina merged commit 413fd75 into master Apr 7, 2017
@mcollina mcollina deleted the avoid-caret branch April 7, 2017 07:05
@AdriVanHoudt
Copy link

I don't see the node 0.6 travis change in the files changed as stated in the title or is that just me?

@mcollina mcollina changed the title Avoid caret during installation, and added node v0.6 to .travis.yml Avoid caret during installation Apr 13, 2017
@mcollina
Copy link
Member Author

I updated the title. We cannot really run our tests on Node v0.6.
Depending using ~ simplify backporting to old NPM versions. The tests passes, but our own test dependencies cannot be installed there anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants