Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundled dependencies #247

Closed
calvinmetcalf opened this issue Nov 14, 2016 · 3 comments
Closed

bundled dependencies #247

calvinmetcalf opened this issue Nov 14, 2016 · 3 comments

Comments

@calvinmetcalf
Copy link
Contributor

we bundled our less common dependencies with version 2.2.0, but this immediately causes issues, specifically with yarn (yarnpkg/yarn#1774 and the tl;dr is that the issue was installing yarn not using yarn). The issue seemed to be about upgrading and the dependencies changing place. So we may need to come up with a different way to bundle them.

@mcollina
Copy link
Member

IMHO we are in an impossible situation. It shouldn't matter about using bundledDependencies or not.

Anyway, we must bump the major if we want to try again, or have our own version of citgm.

@calvinmetcalf
Copy link
Contributor Author

re citgm it was not fresh installs from what I could tell, just upgrades

On Tue, Nov 15, 2016 at 1:55 AM Matteo Collina [email protected]
wrote:

IMHO we are in an impossible situation. It shouldn't matter about using
bundledDependencies or not.

Anyway, we must bump the major if we want to try again, or have our own
version of citgm.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#247 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABE4n8F70FOjfi164cHTx-nD3c06U1Tiks5q-VdXgaJpZM4KxpbJ
.

@mcollina
Copy link
Member

Ahum. Looks like it's an npm bug in computing the tree. Sigh. Whenever we bump the major, it will be a nice change to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants