Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weired output message The signature seems corrupted! on Windows #75

Closed
ShenHongFei opened this issue Feb 22, 2023 · 7 comments
Closed

Weired output message The signature seems corrupted! on Windows #75

ShenHongFei opened this issue Feb 22, 2023 · 7 comments

Comments

@ShenHongFei
Copy link 

node.exe d:/0/node_modules/postject/dist/cli.js d:/t/myprogram.exe NODE_JS_CODE d:/t/index.cjs --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2

output has only one line

The signature seems corrupted!

and the exit code is 0
@ShenHongFei
Copy link
Author

https://github.com/nodejs/postject/blob/main/vendor/lief/src/PE/Parser.cpp#L1004

@RaisinTen
Copy link
Contributor

Looks like a warning. Does running myprogram.exe work as expected?

@ShenHongFei
Copy link
Author

Yes, work as expected

@ShenHongFei ShenHongFei reopened this Feb 22, 2023
@ShenHongFei
Copy link
Author

ShenHongFei commented Feb 22, 2023 •
edited
Loading

If you don't think it's important, you can close this issue.

@RaisinTen
Copy link
Contributor

I think the reason why this happened is because you were attempting to embed the JS file into the official node binary, which is code signed by default by the Node.js Foundation identity. Could you try removing the signature using signtool.exe first and then check if postject works without warnings? You could sign the final executable again with your own signature if you want at the end.

@ShenHongFei
Copy link
Author

Great, the warning disappeared successfully. Thank you very much!

RaisinTen added a commit to RaisinTen/node that referenced this issue Feb 22, 2023
@RaisinTen
doc: add steps about signing the binary in single-executable docs
ce1284b 
We didn't catch this in nodejs#45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen mentioned this issue Feb 22, 2023
Closed
@RaisinTen
Copy link
Contributor

I've sent a PR to document this in the steps in the Node.js docs - nodejs/node#46764

RaisinTen added a commit to nodejs/node that referenced this issue Feb 26, 2023
@RaisinTen
doc: add steps about signing the binary in single-executable docs
4cde39e 
We didn't catch this in #45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RaisinTen RaisinTen mentioned this issue Mar 3, 2023
Merged
targos pushed a commit to nodejs/node that referenced this issue Mar 13, 2023
@RaisinTen @targos
doc: add steps about signing the binary in single-executable docs
33b5c3e 
We didn't catch this in #45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Mar 14, 2023
@RaisinTen @targos
doc: add steps about signing the binary in single-executable docs
48cf984 
We didn't catch this in #45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2023
@RaisinTen @targos
doc: add steps about signing the binary in single-executable docs
15280fb 
We didn't catch this in #45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
doc: add steps about signing the binary in single-executable
f1c9eaf 
We didn't catch this in nodejs/node#45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
doc: add steps about signing the binary in single-executable
9f44b0c 
We didn't catch this in nodejs/node#45038
because the binary wasn't signed by default unlike the official Node.js
binary, which is signed by the Node.js Foundation identity by default.

Refs: nodejs/postject#76 (macOS arm64 part only)
Fixes: nodejs/postject#75
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#46764
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add steps about signing the binary in single-executable docs RaisinTen/node
2 participants
@ShenHongFei @RaisinTen