Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: announce the new discord server #7490

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

meta: announce the new discord server #7490

wants to merge 6 commits into from

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 11, 2025

This PR announces the new official Discord community within the Node.js project. By including a blog post, updating the about page and adding a banner.

@ovflowd ovflowd requested review from a team as code owners February 11, 2025 22:12
@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 17, 2025 5:59pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
 88.71% (739/833) 75.94% (240/316) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.878s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2025
@ovflowd
Copy link
Member Author

ovflowd commented Feb 11, 2025

NOTE -- PLEASE DO NOT MERGE THE PR; Ill manually merge it once it is ready 🙏

@ovflowd ovflowd marked this pull request as draft February 11, 2025 22:27
@AugustinMauroy
Copy link
Member

AugustinMauroy commented Feb 12, 2025 •
edited
Loading

Can we ask foundation to have a custom turtle rocket for discord. Like they do for Paris.
Also Claudio you can take a look at the bluesky automatization to make a post about this blog post

And what about removing slack icon on footer and add discord one ?

@ovflowd
Copy link
Member Author

ovflowd commented Feb 12, 2025

Can we ask foundation to have a custom turtle rocket for discord. Like they do for Paris. Also Claudio you can take a look at the bluesky automatization to make a post about this blog post

And what about removing slack icon on footer and add discord one ?

These are all irrelevant/unrelated to this PR...

@ovflowd ovflowd marked this pull request as ready for review February 16, 2025 20:54
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 16, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 16, 2025
mikeesto
mikeesto reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettier needs to be run here. Otherwise LGTM

MattIPv4
MattIPv4 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth setting up nodejs.org/discord as a redirect so it's easy to swap out the underlying Discord invite if needed?

@ovflowd @MattIPv4
Update apps/site/pages/en/blog/announcements/official-discord-launch-…
855d755 
…announcement.md

Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 17, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcarl vcarl vcarl left review comments

@targos targos targos left review comments

@MattIPv4 MattIPv4 MattIPv4 approved these changes

@mikeesto mikeesto mikeesto left review comments

@Vicinit Vicinit Vicinit left review comments

@flakey5 flakey5 flakey5 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ovflowd @AugustinMauroy @vcarl @targos @MattIPv4 @mikeesto @flakey5 @Vicinit