Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(learn): add article for publishing a typescript package #7279
base: main
Are you sure you want to change the base?
feat(learn): add article for publishing a typescript package #7279
Changes from 16 commits
b20dcbf
2d5d359
86394b6
d583e03
48e2ad9
081b7f2
2a20202
52d3a13
2228ab3
5034918
ddb1cf1
9258389
4906609
07095c6
33e744a
f1703ad
3fd8076
64fd531
7305f8e
13b8e1c
0f7f993
53793f1
4b06b6c
d250a86
6056802
d1f67dc
0b7a3df
b146a69
c68edf0
40e8d7e
bd6909d
eaf9b21
4d36877
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
rootDir
issrc
,src
can be ignored and then everything else will work.These patterns will not correctly ignore any
cts
/mts
files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand why those are special cases. Could you please explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent of this npmignore appears to be to prevent inclusion of source files; but one can handwrite
foo.mts
, which emits asfoo.mjs
andfoo.d.mts
, and so these globs will not handle them.It's moot if you just ignore
src
, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH! You're talking about line 211. The code samples aren't using those extensions, so I didn't account for them to keep things simple and explicit.
Buuut that is a good idea. If we go this route btw, I think I should explain why this is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a multi-line code review comment 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakebailey I believe I have added the necessary samples to cover this now. Please LMK if I missed something.