fix: Unoptimized SVG images #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
ovflowd
reviewed
Nov 19, 2024
ovflowd
reviewed
Nov 19, 2024
ovflowd
reviewed
Nov 19, 2024
styfle
reviewed
Nov 19, 2024
Co-authored-by: Steven <[email protected]> Signed-off-by: Caner Akdas <[email protected]>
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
Can you please run |
github-actions
bot
removed
the
github_actions:pull-request
|
I think we can improve this in Next.js to avoid the custom code here. |
AugustinMauroy
approved these changes
Nov 19, 2024
araujogui
reviewed
Nov 19, 2024
ovflowd
approved these changes
Nov 19, 2024
RedYetiDev
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
github_actions:pull-request
aymen94
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
github_actions:pull-request
|
@styfle should we hold off with this change then and wait for upstream change? |
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 20, 2024
The `<Image>` component doesn't optimize SVG images since they are vector images and can already scale up and down to any width. Therefore, the component will try to detect SVG images based on the file name to avoid sending them to the Image Optimization API at all. This is because the default behavior of the Image Optimization API is to error for SVG images due to the security implications of `<svg>` with nested `<script>`, etc (unless `dangerouslyAllowSVG` is enabled. However, we don't want users to reach for `dangerouslyAllowSVG` because it is not usually what they intended. So instead, we can improve the heuristic for detecting SVG in the `<Image>` component by ignoring the query string. Related to nodejs/nodejs.org#7244
styfle
reviewed
Nov 20, 2024
Co-authored-by: Steven <[email protected]> Signed-off-by: Claudio W <[email protected]>
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
approved these changes
Nov 20, 2024
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Nov 21, 2024
* fix: unoptimized SVG image * chore: review updates * Update apps/site/util/imageUtils.ts Co-authored-by: Steven <[email protected]> Signed-off-by: Caner Akdas <[email protected]> * chore: format files * chore: review update * Update apps/site/util/imageUtils.ts Co-authored-by: Steven <[email protected]> Signed-off-by: Claudio W <[email protected]> --------- Signed-off-by: Caner Akdas <[email protected]> Signed-off-by: Claudio W <[email protected]> Co-authored-by: Steven <[email protected]> Co-authored-by: Claudio W <[email protected]>
wyattjoh
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 28, 2024
The `<Image>` component doesn't optimize SVG images since they are vector images and can already scale up and down to any width. Therefore, the component will try to detect SVG images based on the file name to avoid sending them to the Image Optimization API at all. This is because the default behavior of the Image Optimization API is to error for SVG images due to the security implications of `<svg>` with nested `<script>`, etc (unless `dangerouslyAllowSVG` is enabled. However, we don't want users to reach for `dangerouslyAllowSVG` because it is not usually what they intended. So instead, we can improve the heuristic for detecting SVG in the `<Image>` component by ignoring the query string. Related to nodejs/nodejs.org#7244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, as discussed in #6454 (comment), instead of serving all images with
dangerouslyAllowSVG, we now serve images with the.svgextension as unoptimizedValidation
The images in the preview build should load without any problems
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.