Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: synchronize contribute page with GOVERNANCE.md #7238

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Nov 18, 2024

Some of the content on the contribute page on the website has been out of date. Synchronize it with
https://github.com/nodejs/node/blob/main/GOVERNANCE.md.

In addition, the pull request guide now lives in https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md so update the link as well.

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Some of the content on the contribute page on the website has been
out of date. Synchronize it with
https://github.com/nodejs/node/edit/main/GOVERNANCE.md.
@joyeecheung joyeecheung requested a review from a team as a code owner November 18, 2024 21:51
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 18, 2024 9:52pm

@RedYetiDev RedYetiDev added content Issues/pr concerning content learn Issues/pr concerning the learn section labels Nov 18, 2024
Copy link

github-actions bot commented Nov 19, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.66% (631/696) 72.58% (188/259) 94.48% (120/127)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.624s ⏱️

@RedYetiDev RedYetiDev added this pull request to the merge queue Nov 19, 2024
Merged via the queue into nodejs:main with commit 4fcdd93 Nov 19, 2024
26 of 27 checks passed
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
Some of the content on the contribute page on the website has been
out of date. Synchronize it with
https://github.com/nodejs/node/edit/main/GOVERNANCE.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content learn Issues/pr concerning the learn section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants