Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Credit link changes from X to LinkedIn for Angela Angelini #7236

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

TenzDelek
Copy link
Contributor

Description

Currently, according to the website, credit for our lovely mascot goes to Angela Angelini, however the Twitter account linked no longer exists.

Validation

image

Related Issues

Fixes #7231

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@TenzDelek TenzDelek requested a review from a team as a code owner November 18, 2024 09:22
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 18, 2024 0:11am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheleriva who's close to her, you'd be able to validate that she's OK with us putting her linkedin on the site.

@micheleriva
Copy link
Contributor

@micheleriva who's close to her, you'd be able to validate that she's OK with us putting her linkedin on the site.

Will tell you ASAP

@micheleriva
Copy link
Contributor

@AugustinMauroy LinkedIn is fine. Thank you so much for asking!

Copy link

github-actions bot commented Nov 18, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.38% (592/655) 75.43% (172/228) 94.26% (115/122)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.341s ⏱️

@RedYetiDev RedYetiDev added this pull request to the merge queue Nov 19, 2024
Merged via the queue into nodejs:main with commit 55ac283 Nov 19, 2024
15 checks passed
@RedYetiDev
Copy link
Member

Thanks for your contribution!

bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
* fix:credit change from X to LinedIn

* name changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ang_ngl is no longer on Twitter.
4 participants