-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Backpressuring in Streams" doc: Update pipeline examples #6905
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Require `node:stream/promises` instead of using `utils.promisify`.
b16bb80
to
a4bb10c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! thank you for helping to keep these resources up to date.
Lighthouse Results
|
Unit Test Coverage ReportUnit Test Report
|
Description
In the "Backpressuring in Streams" documentation, update the
pipeline()
examples:stream
, notstream/promises
).stream/promises
instead ofpromisify
.Validation
The updated page, when built locally (
npm run dev
) is http://localhost:3000/en/learn/modules/backpressuring-in-streams#the-problem-with-data-handlingUpdated doc screenshots (click images to see full size):
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.