Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code coverage comment #6895

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: code coverage comment #6895

merged 1 commit into from
Jul 4, 2024

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Jul 4, 2024

Description

On migration to monorepo we missed this line

Validation

It's should display the test coverage on comment

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner July 4, 2024 09:57
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 4, 2024 9:57am

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Unit Test Coverage Report

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd ovflowd added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit e081e57 Jul 4, 2024
15 checks passed
@ovflowd ovflowd deleted the fix-codecov branch July 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants