Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lang box radius #5535

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: lang box radius #5535

merged 2 commits into from
Jul 20, 2023

Conversation

araujogui
Copy link
Member

@araujogui araujogui commented Jul 19, 2023

Description

Fix Codebox's lang box border radius.

Validation

Before:
image

After:
image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner July 19, 2023 20:09
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 8:14pm
nodejs-org-stories 🛑 Canceled (Inspect) Jul 19, 2023 8:14pm

@araujogui araujogui force-pushed the fix/codebox branch 2 times, most recently from 6832fed to 582c50b Compare July 19, 2023 20:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 19, 2023 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 19, 2023 20:14 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting solution!

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Chrome
✅ Firefox
✅ Edge
✅ Mobile Chrome

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aymen94 aymen94 merged commit 01df27d into nodejs:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants