Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unwanted newline which caused the paragraph to break #3254

Merged
merged 3 commits into from
Jun 14, 2020

Conversation

akmalick
Copy link
Contributor

Removed newline after "mentorship, and sponsorship to" to fix broken paragraph.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just opened #3255 to fix this exact same issue (extra newline) as well as fix the spelling error s/aslo/also

I've added the changes i've made here as a suggested change so we could land this PR instead. We had updated formatting through the entire doc to make paragraphs multiple lines, so it would be odd to change that formatting for just this section

locale/en/index.md Outdated Show resolved Hide resolved
locale/en/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins merged commit ce944b7 into nodejs:master Jun 14, 2020
@akmalick
Copy link
Contributor Author

I had just opened #3255 to fix this exact same issue (extra newline) as well as fix the spelling error s/aslo/also

I've added the changes i've made here as a suggested change so we could land this PR instead. We had updated formatting through the entire doc to make paragraphs multiple lines, so it would be odd to change that formatting for just this section

Appreciate that ❤️ @MylesBorins
and a great initiative by Nodejs Team. My love and prayers for all of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants