Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile fixes, small style updates #3210

Merged
merged 13 commits into from
Jun 4, 2020
Merged

Conversation

argyleink
Copy link
Contributor

image

made a few other small design changes, tried to not change much

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally LGTM

@argyleink
Copy link
Contributor Author

image

working across firefox, safari, opera, chrome

scripts/vnu-jar.js Outdated Show resolved Hide resolved
scripts/vnu-jar.js Outdated Show resolved Hide resolved
scripts/vnu-jar.js Outdated Show resolved Hide resolved
@@ -22,7 +22,8 @@ childProcess.exec('java -version', (error, stdout, stderr) => {
'Text run is not in Unicode Normalization Form C.',
// These happen due to the commented out English HTML code some translations have...
// They should be removed at some point
'The document is not mappable to XML 1.0 due to two consecutive hyphens in a comment.'
'The document is not mappable to XML 1.0 due to two consecutive hyphens in a comment.',
'"stroke-color": Property "stroke-color" doesn\'t exist.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'"stroke-color": Property "stroke-color" doesn\'t exist.'
'*stroke-color*'

scripts/vnu-jar.js Outdated Show resolved Hide resolved
scripts/vnu-jar.js Outdated Show resolved Hide resolved
layouts/black-lives-matter.hbs Outdated Show resolved Hide resolved
scripts/vnu-jar.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants