-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution process based on #219. #224
Conversation
opinions of other Collaborators and guidance of the Website Admin Group. | ||
|
||
Collaborators may **close** any issue or pull request they believe is | ||
not relevant for the future of the Node.js project. Where this is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nodejs.org?
SGTM. |
|
||
All pull requests that modify executable code should be subjected to | ||
continuous integration tests on the | ||
[project CI server](https://ci.nodejs.org/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't CI on travis instead of jenkins here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also a jenkins thing that publishes the content in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's also a jenkins thing that publishes the content in master.
What is the website related stuff called?
Contribution process based on #219.
This is a modification of the process we use for core giving certain rights to the admin group.