-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Formation and descriptions of 'how-to-use-buffers.md' #2166
Conversation
1) To differ the versions between v6.0.0 and later, because there're some methods deprecated for 'Buffer' (See:#2165). 2) Add some normal js formations to make snippets of codes shown better.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some editing.
left a bunch of suggestions, but this is an improvement over existing out-of-date text, so removing my request for changes--this can land without them, and changes can always be made subsequently
Left some comments/suggestions, but feel free to land this without addressing them. Getting rid of the Buffer constructor in the example code is more important than addressing my comments, which can be addressed later or not at all. |
Not sure if the YAML date should be changed after an update like this. Kind of wonder if we should either remove display of the date from the |
@Trott The knowledge base isn't shown on the website at the moment, so I'd leave the date for now. +1 for removing it once the content is added to the new website. |
To differ the versions between v6.0.0 and later, because there're some methods deprecated for 'Buffer' (See: Docs > how-to-use-buffers.md #2165).
Add some normal js formations to make snippets of codes shown better.
cc: #1977