Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Formation and descriptions of 'how-to-use-buffers.md' #2166

Merged
2 commits merged into from Apr 5, 2019
Merged

Fix: Formation and descriptions of 'how-to-use-buffers.md' #2166

2 commits merged into from Apr 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2019

  1. To differ the versions between v6.0.0 and later, because there're some methods deprecated for 'Buffer' (See: Docs > how-to-use-buffers.md  #2165).

  2. Add some normal js formations to make snippets of codes shown better.

cc: #1977

1) To differ the versions between v6.0.0 and later, because there're
some methods deprecated for 'Buffer'
(See:#2165).

2) Add some normal js formations to make snippets of codes shown better.
@ghost ghost requested review from Yash-Handa and a team April 2, 2019 07:15
@aymen94
Copy link
Member

aymen94 commented Apr 2, 2019

LGTM

Copy link

@19shubham11 19shubham11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Trott
Trott previously requested changes Apr 2, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some editing.

@Trott Trott dismissed their stale review April 2, 2019 13:35

left a bunch of suggestions, but this is an improvement over existing out-of-date text, so removing my request for changes--this can land without them, and changes can always be made subsequently

@Trott
Copy link
Member

Trott commented Apr 2, 2019

Left some comments/suggestions, but feel free to land this without addressing them. Getting rid of the Buffer constructor in the example code is more important than addressing my comments, which can be addressed later or not at all.

@Trott
Copy link
Member

Trott commented Apr 2, 2019

Not sure if the YAML date should be changed after an update like this. Kind of wonder if we should either remove display of the date from the .hbs template or otherwise clarify if it's the original author date or the last modification date.

@fhemberger
Copy link
Contributor

@Trott The knowledge base isn't shown on the website at the moment, so I'd leave the date for now. +1 for removing it once the content is added to the new website.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants