Improve rendering of foundation link on small devices #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonicdoe
commented
Jul 26, 2018
| @@ -69,11 +69,16 @@ header | |||
| float left | |||
| padding 0 | |||
| margin 0 | |||
| nav | |||
| margin 0 20px | |||
There was a problem hiding this comment.
Why 20 pixels? Because it fits with the main container’s padding:
refack
reviewed
Jul 26, 2018
| a, | ||
| a:link, | ||
| a:active | ||
| padding 0 | ||
|
|
||
| .nav-foundation |
There was a problem hiding this comment.
Why not move L29 (with a copy of L28) to the "large" media breakpoint (around L64)
https://github.com/nodejs/nodejs.org/blob/0c985703cb0f36eee0ba09f357dab55c9241506c/layouts/css/page-modules/_header.styl#L28-L29
There was a problem hiding this comment.
Looking around the codebase, I had the feeling that it was mostly “desktop-first” which is why I opted for this variant. However, I agree that your suggestion makes more sense in this case. Changed 👍
ghost
approved these changes
Jul 26, 2018
refack
approved these changes
Jul 26, 2018
daxlab
approved these changes
Jul 27, 2018
hiroppy
approved these changes
Jul 27, 2018
ckotzbauer
approved these changes
Jul 27, 2018
|
Just go ahead and merge it … I think 6 approving reviews are more than enough. |
|
well done, thanks :) |
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before and after: