Skip to content

Commit

Permalink
docs link update,node v from 12->14
Browse files Browse the repository at this point in the history
- docker hub  link is  pointed to node image in the hub as per the sentence
- official docker docs is pointed to docs for building node-image 
- node v from 12->14
  • Loading branch information
sujanchhetri authored and nschonni committed Jan 12, 2021
1 parent 7904ef9 commit 8cfaff7
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions locale/en/docs/guides/nodejs-docker-webapp.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ touch Dockerfile
Open the `Dockerfile` in your favorite text editor

The first thing we need to do is define from what image we want to build from.
Here we will use the latest LTS (long term support) version `12` of `node`
available from the [Docker Hub](https://hub.docker.com/):
Here we will use the latest LTS (long term support) version `14` of `node`
available from the [Docker Hub](https://hub.docker.com/_/node):

```docker
FROM node:12
FROM node:14
```

Next we create a directory to hold the application code inside the image, this
Expand Down Expand Up @@ -143,7 +143,7 @@ CMD [ "node", "server.js" ]
Your `Dockerfile` should now look like this:

```docker
FROM node:12
FROM node:14
# Create app directory
WORKDIR /usr/src/app
Expand Down Expand Up @@ -194,7 +194,7 @@ $ docker images

# Example
REPOSITORY TAG ID CREATED
node 12 1934b0b038d1 5 days ago
node 14 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down Expand Up @@ -268,6 +268,6 @@ following places:

* [Official Node.js Docker Image](https://hub.docker.com/_/node/)
* [Node.js Docker Best Practices Guide](https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md)
* [Official Docker documentation](https://docs.docker.com/)
* [Official Docker documentation](https://docs.docker.com/get-started/nodejs/build-images/)
* [Docker Tag on Stack Overflow](https://stackoverflow.com/questions/tagged/docker)
* [Docker Subreddit](https://reddit.com/r/docker)

0 comments on commit 8cfaff7

Please sign in to comment.