test: use const and strictEqual in child-process-spawn-error #9951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
child_process
imyller
added
code-and-learn
mscdex
added
the
child_process
princejwesley
approved these changes
Dec 1, 2016
- Using const instead of var for assignments. - let is not used since there are no reassignments or block scopes. - assert.equals was changed to assert.strictEquals
cjihrig
approved these changes
Dec 4, 2016
|
All CI is green except for one host that is still building v8. Consulted with someone from the Build team, and it seems like that's normal when there's a cherry-pick from v8 like there was recently. So...while that's still going, I'm going to start another CI on a host of the same type and hope that it's got the build cached and finishes faster: https://ci.nodejs.org/job/node-test-commit-arm/6292/nodes=armv7-wheezy/ |
|
Both jobs finished successfully. Landing! |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Use const instead of var for assignments. PR-URL: nodejs#9951 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 5be66db |
|
Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Use const instead of var for assignments. PR-URL: #9951 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Use const instead of var for assignments. PR-URL: nodejs#9951 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Use const instead of var for assignments. PR-URL: nodejs#9951 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Use const instead of var for assignments. PR-URL: #9951 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change