Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: swap var->const/let and equal->strictEqual #9888

Closed
wants to merge 1 commit into from
Closed

test: swap var->const/let and equal->strictEqual #9888

wants to merge 1 commit into from

Conversation

pmasucci
Copy link
Contributor

@pmasucci pmasucci commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

@pmasucci
test: swap var->const/let and equal->strictEqual
4e2b8e9 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5064/

lpinca
lpinca reviewed Dec 3, 2016
View reviewed changes
test/parallel/test-tls-no-sslv3.js
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
Copy link
Member

@lpinca lpinca Dec 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please remove this require after the hasCrypto check?

Edit: we can actually move all the requires with the exception of common after the opensslCli check.

jasnell
jasnell approved these changes Dec 4, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the PR and for participating in the code-and-learn!

jasnell pushed a commit that referenced this pull request Dec 4, 2016
@pmasucci @jasnell
test: swap var->const/let and equal->strictEqual
f9274f0 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: #9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 4, 2016

Landed in f9274f0. thank you!

@jasnell jasnell closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@pmasucci @addaleax
test: swap var->const/let and equal->strictEqual
295eb5a 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: #9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@pmasucci @addaleax
test: swap var->const/let and equal->strictEqual
6d5b215 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: nodejs#9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@pmasucci
test: swap var->const/let and equal->strictEqual
00df489 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: nodejs#9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@pmasucci @MylesBorins
test: swap var->const/let and equal->strictEqual
1a73cc5 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: #9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@pmasucci @MylesBorins
test: swap var->const/let and equal->strictEqual
63a3acd 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: #9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@pmasucci @MylesBorins
test: swap var->const/let and equal->strictEqual
7a94f41 
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.

PR-URL: #9888
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pmasucci @Trott @jasnell @lpinca @cjihrig @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot