using strictEquals instead of equals #9873
Conversation
|
@mcrummey May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
imyller
added
the
code-and-learn
|
@mcrummey Did you mean to close this PR? If you update your local branch, it will automatically update the PR. If you're having trouble with git, let us know and someone can walk you through it. |
|
@mcrummey ... can I ask you to please squash the commits in this PR down to a single commit? If you are not familiar with how to do so, please see: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html Once done, you can update this PR simply by force pushing back to your branch. We will be able to get this landed once those are squashed. Thank you! |
mcrummey
force-pushed
the
test-console-make-strict-equal
branch
from
3f1239f
to
d561a0a
Compare
|
FIPS test failure is unrelated. At this time, still waiting on Raspberry Pi and Windows tests to finish. Looking good so far, though. |
|
The one (and hopefully only) Raspberry PI build failure is also unrelated. |
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 073aa2c. |
assert.equal() -> assert.strictEqual() PR-URL: #9873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
assert.equal() -> assert.strictEqual() PR-URL: #9873 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Update console test to use assert.strictEquals instead of assert.equals