Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace assert.equal with assert.strictEqual #9842

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/addons/async-hello-world/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);

binding(5, common.mustCall(function(err, val) {
assert.equal(null, err);
assert.equal(10, val);
assert.strictEqual(err, null);
assert.strictEqual(val, 10);
process.nextTick(common.mustCall(function() {}));
}));
2 changes: 1 addition & 1 deletion test/addons/hello-world-function-export/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding());
assert.strictEqual(binding(), 'world');
console.log('binding.hello() =', binding());
2 changes: 1 addition & 1 deletion test/addons/hello-world/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const common = require('../../common');
var assert = require('assert');
const binding = require(`./build/${common.buildType}/binding`);
assert.equal('world', binding.hello());
assert.strictEqual(binding.hello(), 'world');
console.log('binding.hello() =', binding.hello());
2 changes: 1 addition & 1 deletion test/addons/load-long-path/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ fs.writeFileSync(addonDestinationPath, contents);
// Attempt to load at long path destination
var addon = require(addonDestinationPath);
assert.notEqual(addon, null);
assert.equal(addon.hello(), 'world');
assert.strictEqual(addon.hello(), 'world');
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}

const maxString = buf.toString('latin1');
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ assert.throws(function() {
}, /"toString\(\)" failed/);

var maxString = buf.toString('latin1', 1);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
// Free the memory early instead of at the end of the next assignment
maxString = undefined;

maxString = buf.toString('latin1', 0, kStringMaxLength);
assert.equal(maxString.length, kStringMaxLength);
assert.strictEqual(maxString.length, kStringMaxLength);
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)) {
}

const maxString = buf.toString('utf16le');
assert.equal(maxString.length, (kStringMaxLength + 2) / 2);
assert.strictEqual(maxString.length, (kStringMaxLength + 2) / 2);