Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't spawn child processes in domain test #974

Merged
merged 2 commits into from
Mar 5, 2015
Merged

test: don't spawn child processes in domain test #974

merged 2 commits into from
Mar 5, 2015

Commits on Mar 5, 2015

  1. src: fix -Wempty-body compiler warnings 

    Turn counter macros into no-op instructions when counters are disabled.
Evaluating to nothing makes gcc complain when the macro is used in a
conditional.  Fixes the following warning:

    ../src/tls_wrap.cc:320:5: warning:
    suggest braces around empty body in an 'if' statement [-Wempty-body]
         NODE_COUNT_NET_BYTES_SENT(write_size_);
         ^

PR-URL: nodejs#974
Reviewed-By: Chris Dickinson <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 5, 2015
    Configuration menu
    Copy the full SHA
    b150c98 View commit details
    Browse the repository at this point in the history

  2. test: don't spawn child processes in domain test 

    Make parallel/test-domain-abort-on-uncaught a little easier to debug,
make it execute the tests in the same process instead of each test in
a separate child process.

PR-URL: nodejs#974
Reviewed-By: Chris Dickinson <[email protected]>
    @bnoordhuis
    bnoordhuis committed Mar 5, 2015
    Configuration menu
    Copy the full SHA
    7b554b1 View commit details
    Browse the repository at this point in the history