Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test case of PassThrough #9581

Closed
wants to merge 1 commit into from
Closed

test: add test case of PassThrough #9581

wants to merge 1 commit into from

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Nov 12, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, stream

Description of change

This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016
nodejs/code-and-learn#58

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2016
@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Nov 12, 2016
@yosuke-furukawa
Copy link
Member

CI is green, LGTM.

cjihrig
cjihrig reviewed Nov 12, 2016
View reviewed changes
test/parallel/test-stream2-transform.js
@@ -106,6 +106,14 @@ test('object passthrough', function(t) {
t.end();
});

test('passthrough constructor', function(t) {
var pt = PassThrough();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var -> const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks!

cjihrig
cjihrig approved these changes Nov 12, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@kt3k
test: add test case of PassThrough
e1759a4 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016
nodejs/code-and-learn#58
@kt3k kt3k force-pushed the feature/test-of-passthrough branch from 9ce1d2e to e1759a4 Compare November 12, 2016 14:09
addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

CI is running on https://ci.nodejs.org/job/node-test-pull-request/4834/.

@shigeki
Copy link
Contributor

shigeki commented Nov 18, 2016

Thanks. Landed in 63e889a.

@shigeki shigeki closed this Nov 18, 2016
shigeki pushed a commit that referenced this pull request Nov 18, 2016
@kt3k @shigeki
test: add test case of PassThrough
63e889a 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@kt3k
Copy link
Contributor Author

kt3k commented Nov 18, 2016

Thanks! 😄

@kt3k kt3k deleted the feature/test-of-passthrough branch November 18, 2016 10:30
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@kt3k @addaleax
test: add test case of PassThrough
875d1b9 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@kt3k @addaleax
test: add test case of PassThrough
70691e3 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: nodejs#9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@kt3k @MylesBorins
test: add test case of PassThrough
8345ffb 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@kt3k @MylesBorins
test: add test case of PassThrough
1c294b3 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@kt3k @MylesBorins
test: add test case of PassThrough
44b2bbe 
This commit adds the test case of PassThrough.
This test case checks that PassThrough can
construct without new operator.

This is a part of Code And Learn at NodeFest 2016

Fixes: nodejs/code-and-learn#58
PR-URL: #9581
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kt3k @yosuke-furukawa @shigeki @addaleax @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot