Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo about cluster doc, (eg. -> e.g.) #9568

Closed
wants to merge 1 commit into from

Conversation

YutamaKotaro
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix eg. to e.g. doc/cluster.md

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Nov 12, 2016
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 5d168d728c13a027b484bbb0e92b67198454a565.
Congrats on your first contributions to Node.

@shigeki shigeki closed this Nov 13, 2016
shigeki pushed a commit that referenced this pull request Nov 13, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Sorry, this had an another commit that has not been approved yet.
Landed again in a3dd943 with force push within 10 mins.

addaleax pushed a commit that referenced this pull request Nov 22, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Fixes: nodejs/code-and-learn#58
PR-URL: #9568
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants