doc: update Diag WG info #9329
Merged
doc: update Diag WG info #9329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
mhdawson
approved these changes
Oct 27, 2016
Fishrock123
reviewed
Oct 28, 2016
| * Fostering a tracing and debugging ecosystem. | ||
|
|
||
| * Collaborate with V8 to integrate `v8_inspector`. | ||
| * Collaborate with V8 to integrate `trace_event`. |
There was a problem hiding this comment.
Actually it's to integrate these with Node itself, such as updating the built-in debugger and updating docs for inspector, or collaborating on #9304.
Will update text accordingly.
Fishrock123
reviewed
Oct 28, 2016
|
|
||
| * Collaborate with V8 to integrate `v8_inspector`. | ||
| * Collaborate with V8 to integrate `trace_event`. | ||
| * Maintain and improve `async_wrap` and `async_hooks`. |
There was a problem hiding this comment.
I think this falls under the core collaborators rather than this specific group?
There was a problem hiding this comment.
So far implementing async_wrap has been monitored by the Diagnostic WG. We have maintained the unofficial documentation, issue lists and I/Trevor provides monthly status updates. We also have quite a few APM members, who provides us with usecase information though the WG meetings and issues.
I don't know if maintaining is a part of this, but improving definitely does. Once async_hooks lands we may want to revisit that.
|
I think we should update the wording on some things |
richardlau
reviewed
Oct 31, 2016
| * Collaborate with V8 to integrate `trace_event`. | ||
| * Maintain and improve `async_wrap` and `async_hooks`. | ||
| * Maintain and improve OS trace system integration (e.g. ETW, LTTNG, dtrace). | ||
| * Document diagnostic capabilities and APIs in Node and its components. |
richardlau
reviewed
Oct 31, 2016
| * Maintain and improve OS trace system integration (e.g. ETW, LTTNG, dtrace). | ||
| * Document diagnostic capabilities and APIs in Node and its components. | ||
| * Explore opportunities and gaps, discuss feature requests, and address | ||
| conflicts in Node diagnostics. |
richardlau
reviewed
Oct 31, 2016
| * Document diagnostic capabilities and APIs in Node and its components. | ||
| * Explore opportunities and gaps, discuss feature requests, and address | ||
| conflicts in Node diagnostics. | ||
| * Foster an ecosystem of diagnostics tools for Node. |
|
Updated, @Fishrock123 @AndreasMadsen PTAL. Thanks! |
|
LGTM |
jasnell
approved these changes
Nov 2, 2016
cjihrig
approved these changes
Nov 2, 2016
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: nodejs#9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1f08d35. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics).
Fixes nodejs/diagnostics#69
/cc @nodejs/diagnostics