Fix outdated links #9278
Closed
Fix outdated links #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Oct 25, 2016
| @@ -1,6 +1,6 @@ | |||
| # Building Node with Ninja | |||
|
|
|||
| The purpose of this guide is to show how to build Node.js using [Ninja][], as doing so can be significantly quicker than using `make`. Please see [Ninja's site][Ninja] for installation instructions (unix only). | |||
| The purpose of this guide is to show how to build Node.js using [Ninja](https://github.com/ninja-build/ninja), as doing so can be significantly quicker than using `make`. Please see [Ninja's site](https://ninja-build.org/) for installation instructions (unix only). | |||
There was a problem hiding this comment.
Can you move the URLs to the bottom where the current Ninja link is.
There was a problem hiding this comment.
Addressed! Modified the link at the bottom.
silverwind
approved these changes
Nov 1, 2016
|
Thanks! Landed in bf46f22. |
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2016
PR-URL: #9278 Reviewed-By: Roman Reiss <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
PR-URL: #9278 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9278 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9278 Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Documentation
Description of change
The guild md file still had links to the invalid repository's wiki, which might become out of date now that the project has moved.