v6.8.1 proposal #9104
Merged
v6.8.1 proposal #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression introduced in 0ed8839 that caused additional queued immediate callbacks to be ignored if `clearImmediate(immediate)` was called within the callback for `immediate`. PR-URL: #9086 Fixes: #9084 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
2a4b068 introduced a regression in where checking `instanceof` would fail for `Writable` subclasses inside the subclass constructor, i.e. before `Writable()` was called. Also, calling `null instanceof Writable` or `undefined instanceof Writable` would fail due to accessing the `_writableState` property of the target object. This fixes these problems. PR-URL: #9088 Ref: #8834 (comment) Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs-github-bot
added
meta
evanlucas
force-pushed
the
v6.8.1-proposal
branch
from
b680cef to
061e1f4
Compare
|
/cc @nodejs/ctc @nodejs/release does anyone object to this? |
|
@thealphanerd had mentioned possibly also including #9077 that fixes a build issue on ArchLinux. |
|
ah thanks for the reminder @mscdex! |
I support timely and as-frequent-as-necessary patch releases to fix regressions. 💯 👍 |
Commit 782620f added the define only when building with the bundled zlib. Using a shared zlib results in build breakage: ../src/inspector_agent.cc:179:16: error: assigning to 'Bytef *' (aka 'unsigned char *') from incompatible type 'const uint8_t *' (aka 'const unsigned char *') strm.next_in = PROTOCOL_JSON + 3; ^ ~~~~~~~~~~~~~~~~~ 1 error generated. PR-URL: #9077 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
evanlucas
force-pushed
the
v6.8.1-proposal
branch
from
061e1f4 to
c6a397b
Compare
|
so, there are some freebsd failures that I'm not sure if they are related to the timers fix in here or not? https://ci.nodejs.org/job/node-test-commit-freebsd/4828/nodes=freebsd10-64/tapResults/ Both of these are failing pretty consistently:
|
|
@evanlucas Looking at those failures. |
|
@evanlucas They're known flaky tests I believe. See #8949, #8041, and #7929. I just ran a PR through CI and it came back all green (including freebsd). |
|
Ah ok, I feel better about it then. Thanks y'all. I've already got the binaries built so i'll go ahead and promote them |
PR-URL: #9104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2016-10-14, Version 6.8.1 (Current), @evanlucas
Notable changes
stream.Writablesubclassinstanceofchecks. (Anna Henningsen) #9088Commits
8d2206fe41] - build: add -DZLIB_CONST when building with --shared-zlib (Bradley T. Hughes) #90778c4fab0a28] - stream: fixWritablesubclass instanceof checks (Anna Henningsen) #90887171bd6311] - timers: fix regression with clearImmediate() (Brian White) #9086