tools: disallow extra blank lines at end of files #8920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for a lint rule that disallows empty lines at the end of a file, remove such lines from a number of test files. Refs: nodejs#8918
|
LGTM, CI failures are due to flaky tests/CI infrastructure issues. |
bnoordhuis
approved these changes
Oct 4, 2016
lpinca
reviewed
Oct 4, 2016
| @@ -80,7 +80,7 @@ rules: | |||
| max-len: [2, 80, 2] | |||
| new-parens: 2 | |||
| no-mixed-spaces-and-tabs: 2 | |||
| no-multiple-empty-lines: [2, {max: 2}] | |||
| no-multiple-empty-lines: [2, {max: 2, maxEOF: 0}] | |||
There was a problem hiding this comment.
What about also adding maxBOF: 0 or is it better to do this in another pr?
There was a problem hiding this comment.
What about also adding maxBOF: 0 or is it better to do this in another pr?
Sure, done, rebased, force-pushed.
|
Do we check that files end in |
gibfahn
approved these changes
Oct 4, 2016
Fishrock123
approved these changes
Oct 4, 2016
mhdawson
approved these changes
Oct 4, 2016
|
Updated to include |
silverwind
approved these changes
Oct 4, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 6, 2016
In preparation for a lint rule that disallows empty lines at the end of a file, remove such lines from a number of test files. Refs: nodejs#8918 PR-URL: nodejs#8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 6, 2016
Enabling linting to disallow extra blank lines at the start or end of JavaScript files in our code base. Fixes: nodejs#8918 PR-URL: nodejs#8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
In preparation for a lint rule that disallows empty lines at the end of a file, remove such lines from a number of test files. Refs: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Enabling linting to disallow extra blank lines at the start or end of JavaScript files in our code base. Fixes: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
In preparation for a lint rule that disallows empty lines at the end of a file, remove such lines from a number of test files. Refs: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Enabling linting to disallow extra blank lines at the start or end of JavaScript files in our code base. Fixes: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools test
Description of change
Fixes: #8918