doc: add added: information for globals
#8901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
silverwind
suggested changes
Oct 5, 2016
| filename used in the command line. The value inside a module is the path | ||
| The filename of the code being executed. This is the resolved absolute path | ||
| of this code file. For a main program this is not necessarily the same | ||
| filename used in the command line. The value inside a module is the path |
There was a problem hiding this comment.
Hmm, maybe we should lint for these, if it's possible.
There was a problem hiding this comment.
No strong opinion on this so yeah I can revert this change but when rendered it uses a single space anyway so I don't see the point of using 2+.
lpinca
force-pushed
the
add/added-globals
branch
from
a569d0f
to
1952f70
Compare
|
Should we document the deprecated |
silverwind
approved these changes
Oct 5, 2016
|
@silverwind I'd say probably not... what point is there now? |
|
Just for historical purpose I guess. They were deprecated in 6.0.0 (#1838), by the way. |
|
@silverwind this means re-adding |
|
Yeah, let’s not add |
|
Okay, lets leave them out. LGTM |
|
I’ll start landing this:
|
|
Landed in bd0bedb |
addaleax
pushed a commit
that referenced
this pull request
Oct 6, 2016
Ref: #6578 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Heads up, this doesn’t land cleanly on |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 7, 2016
Ref: nodejs#6578 PR-URL: nodejs#8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 7, 2016
Ref: #6578 Ref: #8964 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
Ref: #6578 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Ref: #6578 Ref: #8964 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Ref: #6578 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Ref: #6578 Ref: #8964 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Ref: #6578 Ref: #8964 PR-URL: #8901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578