test: expand test coverage for url.js #8859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new test case looks good to me and causes line 156 to be exercised whereas current tests do not. 👍 Can you update the commit message so the first line is less than 50 characters? I'd recommend something like this:
|
Currently Line 156 of lib/url.js is not reachable from test-url because there are no example URL which has white space in the front of url. I added one example which can reach that line.
jun-oka
force-pushed
the
test-url-example
branch
from
ad6c0d8
to
f39c173
Compare
|
@Trott Thank you for the notice. I will pay more attention about the number of characters for the first line from next commit. |
targos
approved these changes
Sep 30, 2016
jun-oka
changed the title
cjihrig
approved these changes
Sep 30, 2016
fhinkel
approved these changes
Oct 3, 2016
|
Thank you 👍 . Landed in cad2a2f. |
fhinkel
pushed a commit
that referenced
this pull request
Oct 3, 2016
Currently, line 156 of lib/url.js is not reachable from test-url because there is no example URL which has a white space in the front of the url. I added one example which can reach that line. PR-URL: #8859 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Currently, line 156 of lib/url.js is not reachable from test-url because there is no example URL which has a white space in the front of the url. I added one example which can reach that line. PR-URL: #8859 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Currently, line 156 of lib/url.js is not reachable from test-url because there is no example URL which has a white space in the front of the url. I added one example which can reach that line. PR-URL: #8859 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 18, 2016
Currently, line 156 of lib/url.js is not reachable from test-url because there is no example URL which has a white space in the front of the url. I added one example which can reach that line. PR-URL: #8859 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test url
lib/url
Description of change
Currently Line 156 of lib/url.js is not reachable from test-url because there are no example URL which has white space in the front of url.
I added one example which can reach that line.