benchmark: make v8-bench.js output consistent #8564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way v8-bench.js reports its performance to be consistent with other benchmarks.
nodejs-github-bot
added
the
benchmark
|
LGTM |
|
@nodejs/benchmarking ... comments? |
|
Consistency is always a good thing. LGTM |
bzoz
added a commit
that referenced
this pull request
Sep 26, 2016
This changes the way v8-bench.js reports its performance to be consistent with other benchmarks. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> PR-URL: #8564
|
Landed in 9e5a06e |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
This changes the way v8-bench.js reports its performance to be consistent with other benchmarks. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> PR-URL: #8564
geek
pushed a commit
to geek/node
that referenced
this pull request
Sep 30, 2016
This changes the way v8-bench.js reports its performance to be consistent with other benchmarks. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> PR-URL: nodejs#8564
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.
cc @nodejs/benchmarking